-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev minor #1536
Dev minor #1536
Conversation
* improve ci/cd runtime * update prompt tests
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
* improve ci/cd runtime * update prompt tests * add azure * up * up
* revert latest ingestion changes * revert latest ingestion changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 9acc0e6 in 1 minute and 32 seconds
More details
- Looked at
2581
lines of code in35
files - Skipped
1
files when reviewing. - Skipped posting
8
drafted comments based on config settings.
1. py/tests/integration/local_harness.py:126
- Draft comment:
The import statement has been updated to userunner_sdk_basic
instead ofrunner_sdk
. Ensure that this module exists and is correctly configured for the tests. - Reason this comment was not posted:
Confidence changes required:50%
The PR changes the test runner script to use a new modulerunner_sdk_basic.py
instead ofrunner_sdk.py
. This change is consistent across multiple files, indicating a refactor or renaming of the test module. The change seems intentional and consistent.
2. py/tests/integration/runner_sdk_basic.py:56
- Draft comment:
The test functiontest_ingest_sample_file_3_sdk
usesrunner_sdk_basic.py
instead ofrunner_sdk.py
. Ensure that this module is correctly configured for the tests. - Reason this comment was not posted:
Confidence changes required:50%
The PR changes the test runner script to use a new modulerunner_sdk_basic.py
instead ofrunner_sdk.py
. This change is consistent across multiple files, indicating a refactor or renaming of the test module. The change seems intentional and consistent.
3. py/tests/integration/runner_sdk_basic.py:103
- Draft comment:
The test functiontest_reingest_sample_file_sdk
usesrunner_sdk_basic.py
instead ofrunner_sdk.py
. Ensure that this module is correctly configured for the tests. - Reason this comment was not posted:
Confidence changes required:50%
The PR changes the test runner script to use a new modulerunner_sdk_basic.py
instead ofrunner_sdk.py
. This change is consistent across multiple files, indicating a refactor or renaming of the test module. The change seems intentional and consistent.
4. py/tests/integration/runner_sdk_basic.py:204
- Draft comment:
The test functiontest_get_prompt
usesrunner_sdk_basic.py
instead ofrunner_sdk.py
. Ensure that this module is correctly configured for the tests. - Reason this comment was not posted:
Confidence changes required:50%
The PR changes the test runner script to use a new modulerunner_sdk_basic.py
instead ofrunner_sdk.py
. This change is consistent across multiple files, indicating a refactor or renaming of the test module. The change seems intentional and consistent.
5. py/tests/integration/runner_sdk_basic.py:217
- Draft comment:
The test functiontest_rag_response_sample_file_sdk
usesrunner_sdk_basic.py
instead ofrunner_sdk.py
. Ensure that this module is correctly configured for the tests. - Reason this comment was not posted:
Confidence changes required:50%
The PR changes the test runner script to use a new modulerunner_sdk_basic.py
instead ofrunner_sdk.py
. This change is consistent across multiple files, indicating a refactor or renaming of the test module. The change seems intentional and consistent.
6. py/tests/integration/runner_sdk_basic.py:233
- Draft comment:
The test functiontest_vector_search_sample_file_filter_sdk
usesrunner_sdk_basic.py
instead ofrunner_sdk.py
. Ensure that this module is correctly configured for the tests. - Reason this comment was not posted:
Confidence changes required:50%
The PR changes the test runner script to use a new modulerunner_sdk_basic.py
instead ofrunner_sdk.py
. This change is consistent across multiple files, indicating a refactor or renaming of the test module. The change seems intentional and consistent.
7. py/tests/integration/runner_sdk_basic.py:248
- Draft comment:
The test functiontest_hybrid_search_sample_file_filter_sdk
usesrunner_sdk_basic.py
instead ofrunner_sdk.py
. Ensure that this module is correctly configured for the tests. - Reason this comment was not posted:
Confidence changes required:50%
The PR changes the test runner script to use a new modulerunner_sdk_basic.py
instead ofrunner_sdk.py
. This change is consistent across multiple files, indicating a refactor or renaming of the test module. The change seems intentional and consistent.
8. py/core/configs/r2r_azure.toml:1
-
Draft comment:
r2r_azure.toml
is functionally similar tofull_azure.toml
except for orchestration settings. Consider extendingfull_azure.toml
if orchestration is not needed. -
Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment provides a suggestion to consider extending another configuration file (full_azure.toml
) instead of creating a new one if orchestration is not needed. This could be a useful suggestion if it helps reduce redundancy or improve maintainability. However, without knowing the specific requirements or context of the project, it's speculative whether this suggestion is actionable or necessary.
The comment assumes that the author might not need orchestration settings, which may not be the case. It also doesn't provide strong evidence that extendingfull_azure.toml
is a better approach.
The suggestion could be useful if the author is unaware of the similarities and the potential to extendfull_azure.toml
. However, without clear evidence that this change is needed, it remains speculative.
The comment is speculative and does not provide strong evidence that a change is required. It should be deleted as it does not meet the criteria for a necessary code change.
Workflow ID: wflow_xW5ac0xrKCGhsWDq
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
This pull request enhances the R2R project's testing infrastructure, updates configurations for Azure, improves ingestion and orchestration processes, and refines prompt handling logic.
runner_sdk.py
torunner_sdk_basic.py
and update references in.github/actions/run-sdk-auth-tests/action.yml
and other action files.local_harness.py
for running integration tests locally with detailed logging and result tracking.local_harness.py
to include new test categories likesdk-prompts
.test_prompt_handler.py
for prompt caching and retrieval.full_azure.toml
andr2r_azure.toml
for Azure-specific configurations.full.toml
to usezerox
PDF parser.pyproject.toml
to change Python version requirement to>=3.10,<3.13
.ingestion_router.py
andkg_router.py
to supportrun_with_orchestration
flag for synchronous operations.R2RIngestionProvider
andUnstructuredIngestionProvider
to handle parser overrides and improve error handling.PostgresPromptHandler
inprompt.py
to improve cache invalidation and update logic.test_prompt_handler.py
.This description was created by for 9acc0e6. It will automatically update as commits are pushed.