-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch/add azure to workflows #1537
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 954c59b in 2 minutes and 10 seconds
More details
- Looked at
2269
lines of code in28
files - Skipped
0
files when reviewing. - Skipped posting
9
drafted comments based on config settings.
1. .github/actions/run-sdk-auth-tests/action.yml:10
- Draft comment:
The test runner has been changed fromrunner_sdk.py
torunner_sdk_basic.py
. Ensure thatrunner_sdk_basic.py
contains all necessary tests and configurations that were present inrunner_sdk.py
. This change is also present in other workflow files. - Reason this comment was not posted:
Confidence changes required:50%
The PR changes the test runner to userunner_sdk_basic.py
instead ofrunner_sdk.py
. This change is consistent across multiple files, indicating a shift in the testing strategy. However, the PR description does not provide context for this change, which could be important for understanding the intent and ensuring the correct tests are being run.
2. .github/actions/start-r2r-full/action.yml:15
- Draft comment:
The configuration has been changed fromfull
tofull_azure
. Ensure that thefull_azure
configuration file is correctly set up for the intended tests. This change is likely intended to test Azure-specific configurations. - Reason this comment was not posted:
Confidence changes required:50%
The PR modifies the ingestion command to use a different configuration file (full_azure
instead offull
). This change is likely intended to test Azure-specific configurations. However, the PR description does not provide context for this change, which could be important for understanding the intent and ensuring the correct configurations are being tested.
3. .github/actions/start-r2r-light/action.yml:10
- Draft comment:
The configuration forr2r serve
has been changed tor2r_azure
. Ensure that ther2r_azure
configuration file is correctly set up for the intended tests. This change is likely intended to test Azure-specific configurations. - Reason this comment was not posted:
Confidence changes required:50%
The PR changes the configuration for ther2r serve
command to user2r_azure
. This change is likely intended to test Azure-specific configurations. However, the PR description does not provide context for this change, which could be important for understanding the intent and ensuring the correct configurations are being tested.
4. .github/workflows/r2r-full-py-integration-tests-graphrag.yml:6
- Draft comment:
Branchesdev
anddev-minor
have been removed from the trigger list. Ensure that these branches are no longer needed for triggering this workflow. - Reason this comment was not posted:
Confidence changes required:50%
The PR removes branchesdev
anddev-minor
from the list of branches that trigger the workflow. This change might be intended to streamline the CI/CD process, but it should be confirmed that these branches are no longer needed for triggering tests.
5. .github/workflows/r2r-full-py-integration-tests.yml:6
- Draft comment:
Branchesdev
anddev-minor
have been removed from the trigger list. Ensure that these branches are no longer needed for triggering this workflow. - Reason this comment was not posted:
Confidence changes required:50%
The PR removes branchesdev
anddev-minor
from the list of branches that trigger the workflow. This change might be intended to streamline the CI/CD process, but it should be confirmed that these branches are no longer needed for triggering tests.
6. .github/workflows/r2r-light-py-integration-tests-graphrag.yml:6
- Draft comment:
Branchesdev
anddev-minor
have been removed from the trigger list. Ensure that these branches are no longer needed for triggering this workflow. - Reason this comment was not posted:
Confidence changes required:50%
The PR removes branchesdev
anddev-minor
from the list of branches that trigger the workflow. This change might be intended to streamline the CI/CD process, but it should be confirmed that these branches are no longer needed for triggering tests.
7. py/core/main/api/ingestion_router.py:413
- Draft comment:
The return type ofingest_chunks_app
has been changed from a dictionary to a list containing a dictionary. Ensure that all client code is updated to handle the new response format. - Reason this comment was not posted:
Confidence changes required:50%
The PR changes the return type ofingest_chunks_app
from a dictionary to a list containing a dictionary. This change might affect how the response is handled by clients expecting a dictionary. Ensure that all client code is updated to handle the new response format.
8. py/core/main/api/kg_router.py:140
- Draft comment:
A new parameterrun_with_orchestration
has been added. Ensure that this parameter is correctly handled in all relevant parts of the codebase. - Reason this comment was not posted:
Confidence changes required:50%
The PR adds a new parameterrun_with_orchestration
to thecreate_graph
andenrich_graph
methods. This parameter allows the user to choose whether to run with orchestration. Ensure that this parameter is correctly handled in all relevant parts of the codebase.
9. py/core/configs/full_azure.toml:1
-
Draft comment:
full_azure.toml
is a duplicate ofr2r_azure.toml
. Both files have nearly identical settings for Azure configurations. Consider consolidating them to avoid redundancy. -
Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_Jn7FV128sHI2Kn97
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
py/core/configs/r2r_azure.toml
Outdated
@@ -0,0 +1,40 @@ | |||
# A config which overrides all instances of `openai` with `azure` in the `r2r.toml` config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The r2r_azure.toml
file is a duplicate of the existing r2r.toml
file, with the main difference being the provider (Azure vs OpenAI). Consider refactoring to avoid duplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 7b070da in 28 seconds
More details
- Looked at
89
lines of code in6
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_4mn8IPbSdR9RUMRV
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 7dac6f4 in 28 seconds
More details
- Looked at
64
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_zNVvWUrQevuyJn6Y
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
* improve ci/cd runtime (#1535) * improve ci/cd runtime * update prompt tests * Support Python ^3.10 (#1534) * Patch/add azure to workflows (#1537) * improve ci/cd runtime * update prompt tests * add azure * up * up * revert latest ingestion changes (#1539) * revert latest ingestion changes * revert latest ingestion changes * Update pyproject.toml --------- Co-authored-by: Nolan Tremelling <34580718+NolanTrem@users.noreply.github.com>
* improve ci/cd runtime (#1535) * improve ci/cd runtime * update prompt tests * Support Python ^3.10 (#1534) * Patch/add azure to workflows (#1537) * improve ci/cd runtime * update prompt tests * add azure * up * up * revert latest ingestion changes (#1539) * revert latest ingestion changes * revert latest ingestion changes * Update pyproject.toml * Update local_llm.toml (#1542) * Update local_llm.toml * Update pyproject.toml * Update full_azure.toml * expose user verification code --------- Co-authored-by: Nolan Tremelling <34580718+NolanTrem@users.noreply.github.com>
Important
Integrates Azure configurations into workflows, updates orchestration logic, and modifies tests to support Azure settings.
full_azure.toml
andr2r_azure.toml
for Azure-specific settings.start-r2r-full/action.yml
andstart-r2r-light/action.yml
to use Azure configurations.r2r-full-integration-deep-dive-tests.yml
,r2r-js-sdk-integration-tests.yml
, andr2r-light-py-integration-tests.yml
.dev
anddev-minor
branches fromr2r-full-py-integration-tests.yml
andr2r-light-py-integration-tests.yml
.run_with_orchestration
option iningestion_router.py
andkg_router.py
to toggle orchestration.simple/kg_workflow.py
to handle orchestration logic.runner_sdk.py
torunner_sdk_basic.py
.local_harness.py
for local test execution.runner_sdk_basic.py
.This description was created by for d75dd97. It will automatically update as commits are pushed.