-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nolan/collections summary #1685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 13d5823 in 33 seconds
More details
- Looked at
1059
lines of code in23
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. py/sdk/v3/collections.py:112
- Draft comment:
The conditionif generate_description
is redundant sincegenerate_description
is already a boolean and defaults toFalse
. Consider simplifying the check. - Reason this comment was not posted:
Confidence changes required:50%
The code is checking for a condition that is not necessary. The conditionif generate_description
is redundant becausegenerate_description
is already a boolean and defaults toFalse
. The check can be simplified.
Workflow ID: wflow_uMpcwkUKCiPHJVdc
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
…nto Nolan/CollectionsSummary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on d8c7ffe in 33 seconds
More details
- Looked at
38
lines of code in3
files - Skipped
1
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. py/core/providers/database/document.py:453
- Draft comment:
Remove the leftover debug print statement for cleaner code. - Reason this comment was not posted:
Confidence changes required:50%
The print statement is a leftover debug statement and should be removed for cleaner code.
Workflow ID: wflow_wOIFXqdpUwKmmZN5
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on e5612fa in 1 minute and 5 seconds
More details
- Looked at
272
lines of code in14
files - Skipped
0
files when reviewing. - Skipped posting
4
drafted comments based on config settings.
1. py/core/main/services/kg_service.py:1044
- Draft comment:
Replace print statements with proper logging. This applies to other print statements in this file as well. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. py/core/main/services/management_service.py:313
- Draft comment:
Replace print statements with proper logging. This applies to other print statements in this file as well. - Reason this comment was not posted:
Marked as duplicate.
3. py/core/providers/database/postgres.py:233
- Draft comment:
Replace print statements with proper logging. This applies to other print statements in this file as well. - Reason this comment was not posted:
Marked as duplicate.
4. py/sdk/v3/documents.py:150
- Draft comment:
Replace print statements with proper logging. This applies to other print statements in this file as well. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_WNLXt29ytuzxPbsI
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Add synthetic description generation for collections, remove unused prompt tuning code, and update database and prompt configurations.
generateDescription
parameter toupdate_collection
incollections.ts
andcollections_router.py
for synthetic description generation.tune_prompt
functionality fromtest_v3_sdk_graph.py
,abstractions.py
,factory.py
, andkg_service.py
.collection_summary_system_prompt
andcollection_summary_task_prompt
toDatabaseConfig
indatabase.py
.collections_overview
anddocuments_in_collection
queries incollection.py
to include summaries.default_collection_summary.yaml
for collection-level summaries.graphrag_communities.yaml
for new prompt structures.CollectionsIntegrationSuperUser.test.ts
.r2rClientIntegrationSuperUser.test.ts
andr2rClientIntegrationUser.test.ts
.r2r.toml
to include new prompt settings.prompt_tuning.yaml
and related code inprompt_tuning.py
..pre-commit-config.yaml
.This description was created by for e5612fa. It will automatically update as commits are pushed.