Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nolan/collections summary #1685

Merged
merged 8 commits into from
Dec 11, 2024
Merged

Nolan/collections summary #1685

merged 8 commits into from
Dec 11, 2024

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Dec 11, 2024

Important

Add synthetic description generation for collections, remove unused prompt tuning code, and update database and prompt configurations.

  • Behavior:
    • Add generateDescription parameter to update_collection in collections.ts and collections_router.py for synthetic description generation.
    • Remove tune_prompt functionality from test_v3_sdk_graph.py, abstractions.py, factory.py, and kg_service.py.
  • Database:
    • Add collection_summary_system_prompt and collection_summary_task_prompt to DatabaseConfig in database.py.
    • Update collections_overview and documents_in_collection queries in collection.py to include summaries.
  • Prompts:
    • Add default_collection_summary.yaml for collection-level summaries.
    • Update graphrag_communities.yaml for new prompt structures.
  • Tests:
    • Add tests for synthetic description generation in CollectionsIntegrationSuperUser.test.ts.
    • Remove outdated tests in r2rClientIntegrationSuperUser.test.ts and r2rClientIntegrationUser.test.ts.
  • Misc:
    • Update r2r.toml to include new prompt settings.
    • Remove prompt_tuning.yaml and related code in prompt_tuning.py.
    • Add pre-commit hook to check for print statements in .pre-commit-config.yaml.

This description was created by Ellipsis for e5612fa. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 13d5823 in 33 seconds

More details
  • Looked at 1059 lines of code in 23 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/sdk/v3/collections.py:112
  • Draft comment:
    The condition if generate_description is redundant since generate_description is already a boolean and defaults to False. Consider simplifying the check.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code is checking for a condition that is not necessary. The condition if generate_description is redundant because generate_description is already a boolean and defaults to False. The check can be simplified.

Workflow ID: wflow_uMpcwkUKCiPHJVdc


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on d8c7ffe in 33 seconds

More details
  • Looked at 38 lines of code in 3 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/core/providers/database/document.py:453
  • Draft comment:
    Remove the leftover debug print statement for cleaner code.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The print statement is a leftover debug statement and should be removed for cleaner code.

Workflow ID: wflow_wOIFXqdpUwKmmZN5


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on e5612fa in 1 minute and 5 seconds

More details
  • Looked at 272 lines of code in 14 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. py/core/main/services/kg_service.py:1044
  • Draft comment:
    Replace print statements with proper logging. This applies to other print statements in this file as well.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. py/core/main/services/management_service.py:313
  • Draft comment:
    Replace print statements with proper logging. This applies to other print statements in this file as well.
  • Reason this comment was not posted:
    Marked as duplicate.
3. py/core/providers/database/postgres.py:233
  • Draft comment:
    Replace print statements with proper logging. This applies to other print statements in this file as well.
  • Reason this comment was not posted:
    Marked as duplicate.
4. py/sdk/v3/documents.py:150
  • Draft comment:
    Replace print statements with proper logging. This applies to other print statements in this file as well.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_WNLXt29ytuzxPbsI


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit 87222ec into main Dec 11, 2024
13 of 31 checks passed
@NolanTrem NolanTrem deleted the Nolan/CollectionsSummary branch December 11, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant