Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove V2 SDK #1744

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Remove V2 SDK #1744

merged 2 commits into from
Dec 31, 2024

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Dec 31, 2024

Important

Remove V2 SDK from JavaScript and Python codebases, including related files and references.

  • JavaScript SDK:
    • Removed models.tsx and its exports from index.ts.
    • Removed V2-specific imports and code from r2rClient.ts.
  • Python SDK:
    • Removed V2 mixins from async_client.py and sync_client.py.
    • Deleted V2-related files in py/sdk/v2/ directory.
    • Updated R2RAsyncClient and R2RClient to remove V2 references.

This description was created by Ellipsis for 7427ea7. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7427ea7 in 58 seconds

More details
  • Looked at 6289 lines of code in 21 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_IkziZyl8h58gm8JW


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit 1b737a6 into main Dec 31, 2024
14 of 15 checks passed
@NolanTrem NolanTrem deleted the Nolan/RemoveOldSDK branch December 31, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant