Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS-867 Added docker file and gpg public key for data encryption #72

Merged
merged 6 commits into from
Mar 12, 2024

Conversation

churnikov
Copy link
Contributor

@churnikov churnikov commented Mar 11, 2024

This PR adds docker image that will be used on rancher to encrypt backup files.

Inside of it there are psql client, gpg and non root user under 1000 id

In order to encrypt it will run the following command:
gpg --batch --yes --encrypt -r RECIPIENT_EMAIL --trust-model always --output OUTPUT_FILE

@churnikov churnikov added the feature New feature label Mar 11, 2024
@churnikov churnikov requested a review from a team March 11, 2024 16:28
@churnikov churnikov self-assigned this Mar 11, 2024
@churnikov
Copy link
Contributor Author

churnikov commented Mar 12, 2024

Error: serve-rstudio/Dockerfile:74 SC2016 info: Expressions don't expand in single quotes, use double quotes for that.

Regarding that one, I'm not sure if I should fix this. It seems like this is how it works right now, and it's intentional

@alfredeen
Copy link
Member

Error: serve-rstudio/Dockerfile:74 SC2016 info: Expressions don't expand in single quotes, use double quotes for that.

Regarding that one, I'm not sure if I should fix this. It seems like this is how it works right now, and it's intentional

Yes it is possibly ok here. Maybe we should add to the hadolint ignore file.

Copy link
Member

@alfredeen alfredeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustment. lgtm now.

@churnikov churnikov merged commit 0cf4fbf into main Mar 12, 2024
6 checks passed
@churnikov churnikov deleted the SS-867-docker-image-for-encryption branch March 12, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants