Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url parsing with splitted scheme #9322

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

touilleMan
Copy link
Member

close #9316

@touilleMan touilleMan requested a review from a team as a code owner January 10, 2025 14:40
@touilleMan touilleMan force-pushed the fix-url-parsing-with-splitted-scheme branch from b7ec7e6 to 6abc81b Compare January 10, 2025 14:58
Copy link
Contributor

@FirelightFlagboy FirelightFlagboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR be backported?

libparsec/crates/types/tests/unit/addr.rs Show resolved Hide resolved
@touilleMan
Copy link
Member Author

Should this PR be backported?

I would say it's not worth the trouble since it's a rather peculiar bug, but I let @mmmarcos decide ;-)

@touilleMan touilleMan added this pull request to the merge queue Jan 13, 2025
Merged via the queue into master with commit ca663ed Jan 13, 2025
14 checks passed
@touilleMan touilleMan deleted the fix-url-parsing-with-splitted-scheme branch January 13, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: internal error: entered unreachable code: scheme can only be http or https
2 participants