Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make isAddress more async #464

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Make isAddress more async #464

merged 2 commits into from
Feb 21, 2023

Conversation

alexkeating
Copy link
Collaborator

Description

  • Make isAddress more async, and handle errors in isAddress

Closes #373

@netlify
Copy link

netlify bot commented Feb 17, 2023

Deploy Preview for jolly-shaw-20fe62 ready!

Name Link
🔨 Latest commit 330c401
🔍 Latest deploy log https://app.netlify.com/sites/jolly-shaw-20fe62/deploys/63f52ceb4c85f600095676aa
😎 Deploy Preview https://deploy-preview-464--jolly-shaw-20fe62.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@alexkeating alexkeating changed the title Make isAddress async Make isAddress more async Feb 17, 2023
Copy link
Member

@garyghayrat garyghayrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mds1 mds1 force-pushed the chore/async-promise branch from e8275fe to 330c401 Compare February 21, 2023 20:43
@github-actions
Copy link

Coverage after merging chore/async-promise into master will be

86.45%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts-periphery/src
   UmbraBatchSend.sol93.55%100%75%94.74%85
   UniswapWithdrawHook.sol77.78%100%50%80%44
umbra-js/src
   ethers.ts86.27%100%75%100%
   types.ts50%100%0%100%
umbra-js/src/classes
   KeyPair.ts98.65%96.49%100%100%31–32
   RandomNumber.ts100%100%100%100%
   StealthKeyRegistry.ts100%100%100%100%
   TxHistoryProvider.ts85.71%86.67%66.67%87.50%11, 26, 46, 50, 8
   Umbra.ts79.77%74.19%76%83.66%134–135, 211–212, 212–213, 222–223, 241, 287–290, 352, 360, 360–362, 364, 366, 386, 386, 386–387, 392–393, 396, 399, 415, 432–433, 481, 515, 532, 545–546, 556–557, 580–581, 657, 660, 660, 660, 663, 670, 670, 677, 681, 681, 681–682, 695, 699, 702–703, 709–711, 718, 718, 718–721
umbra-js/src/utils
   cns.ts50%33.33%50%55%33–36, 40, 40, 40, 40, 40–41, 44–46
   constants.ts100%100%100%100%
   ens.ts38.89%25%33.33%44%26–27, 35, 56–57, 57, 57–58, 63–64, 66, 70, 70, 70, 70, 70–71, 75–77
   utils.ts81.79%73.15%81.25%87.43%102, 120–121, 168, 221, 235–236, 236, 236, 259, 261–262, 271, 271, 271–272, 274, 277, 286–287, 331, 331, 331, 351, 374, 376, 381, 389–393, 396, 438–439, 439, 439–441, 441, 441, 541, 546, 58–59, 84, 92, 94–96
umbra-js/test
   testPrivateKeys.ts100%100%100%100%
   utils.ts100%100%100%100%

@mds1 mds1 merged commit 65224fb into master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use asynchronous Promise when checking address input
3 participants