Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete faster file cache #219

Merged
merged 89 commits into from
Jun 12, 2024
Merged

Delete faster file cache #219

merged 89 commits into from
Jun 12, 2024

Conversation

Dabnsky
Copy link
Contributor

@Dabnsky Dabnsky commented May 23, 2024 •
edited
Loading

What type of Pull Request is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Describe your changes in brief

These changes optimizes the deletions and other open() calls that the windows OS invokes on files that don't require downloaded data.

summarized changes:

Moved the download logic out of the filecache.OpenFile() into downloadFile(). OpenFile() now spits out an empty handle with flags and filemode data stored in the handle.values map that downloadFile() uses.

downloadFile() is invoked by ReadInBuffer() and WriteFile() when the handle.value exists.

Checklist

  • Tested locally
  • Added new dependencies
  • Updated documentation
  • Added tests

Related Issues

  • Related Issue #
  • Closes #

Dabnsky and others added 20 commits February 1, 2024 14:42
@Dabnsky
Added check on Atime on item to condition
ee3d7ad
@Dabnsky
WIP nested if to check Atime
6391dd5
@Dabnsky
Revert "WIP nested if to check Atime"
5934cef 
This reverts commit 6391dd5.
@Dabnsky
Revert "Added check on Atime on item to condition"
df7a8f3 
This reverts commit ee3d7ad.
@Dabnsky
added debug lines in Read() and Write()
dafa996
@Dabnsky
WIP Moved file_cache : Openfile call to Read() and Write()
8483de9
@Dabnsky
WIP Removed open() call in Write(). Troubleshooting file interface la…
bd0b50b 
…g and write issues.
@Dabnsky
Revert "WIP Removed open() call in Write(). Troubleshooting file inte…
3edf430 
…rface lag and write issues."

This reverts commit bd0b50b.
@Dabnsky
Revert "WIP Moved file_cache : Openfile call to Read() and Write()"
771c329 
This reverts commit 8483de9.
@Dabnsky
Merge commit 'c16b7102d8cc5d1ecbc7e0a386a54fdd887c4322' into delete-f…
b0f3457 
…aster
@Dabnsky
modified ReadInBuffer() to recieve handleID and load handleID
dc3640d
@Dabnsky
Revert "modified ReadInBuffer() to recieve handleID and load handleID"
8aa6960 
This reverts commit dc3640d.
@Dabnsky
set up download() and getHandleData()
35712ba
@Dabnsky
added call to getHandleData() from ReadInBuffer()
1ea5471
@Dabnsky
added call to getHandleData() in WriteFile()
cacc0b3
@Dabnsky
removed redundant fileObj nil check
08ac9d9
@Dabnsky
added additional handlemap.Handle var to replace options.Handle for R…
cdd2d77 
…eadInBuffer()
@Dabnsky
added additional handlemap.Handle var to replace options.Handle for W…
b5d1dfc 
…riteFile()
@Dabnsky
updated println() into log.Err and log.Debug
e58cc12
@Dabnsky
Merge remote-tracking branch 'origin/main' into delete-faster-fileCache
a47c5c3
@Dabnsky
-changed test to call DownloadFile()
246bcf7 
-exported download() to DownlaodFile() for tests
-added isDownloadRequired logic in TruncateFile()
@Dabnsky Dabnsky requested a review from ahuynh1289 May 24, 2024 17:53
foodprocessor
foodprocessor requested changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@foodprocessor foodprocessor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close!

component/file_cache/file_cache.go Outdated Show resolved Hide resolved
component/file_cache/file_cache.go Outdated Show resolved Hide resolved
component/file_cache/file_cache.go Outdated Show resolved Hide resolved
component/file_cache/file_cache.go Outdated Show resolved Hide resolved
component/file_cache/file_cache.go Outdated Show resolved Hide resolved
foodprocessor
foodprocessor approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@foodprocessor foodprocessor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! 🥳🥳🥳

@Dabnsky Dabnsky requested a review from jfantinhardesty June 12, 2024 19:28
@Dabnsky Dabnsky requested a review from jfantinhardesty June 12, 2024 22:20
jfantinhardesty
jfantinhardesty requested changes Jun 12, 2024
View reviewed changes
component/file_cache/file_cache_test.go Outdated Show resolved Hide resolved
component/file_cache/file_cache_test.go Outdated Show resolved Hide resolved
component/file_cache/file_cache_test.go Outdated Show resolved Hide resolved
component/file_cache/file_cache_test.go Outdated Show resolved Hide resolved
component/file_cache/file_cache_test.go Outdated Show resolved Hide resolved
@Dabnsky Dabnsky requested a review from jfantinhardesty June 12, 2024 22:41
@Dabnsky Dabnsky merged commit 3fcfe20 into main Jun 12, 2024
17 checks passed
@Dabnsky Dabnsky deleted the delete-faster-fileCache branch June 12, 2024 23:27
@jfantinhardesty jfantinhardesty linked an issue Oct 30, 2024 that may be closed by this pull request
File Deletion in Windows File Explorer Takes ~1s per File #191
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfantinhardesty jfantinhardesty jfantinhardesty approved these changes

@foodprocessor foodprocessor foodprocessor approved these changes

@Ferelith-maker Ferelith-maker Awaiting requested review from Ferelith-maker Ferelith-maker is a code owner

@ahuynh1289 ahuynh1289 Awaiting requested review from ahuynh1289

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File Deletion in Windows File Explorer Takes ~1s per File
3 participants
@Dabnsky @foodprocessor @jfantinhardesty