Code

Consistency for File State#374

Code

Merged

foodprocessor merged 64 commits intomainSeagate/cloudfuse:mainfrom delete-files-synchronouslySeagate/cloudfuse:delete-files-synchronouslyCopy head branch name to clipboardJan 15, 2025

+519-492

Commits

Commits on Nov 25, 2024

• Delete file immediately (not async) in CachePurge

  foodprocessor

  committed
  1350081

  Copy full SHA for 1350081

• Set test timeout to 1s.

  Show description for e58a516
  foodprocessor

  committed
  e58a516

  Copy full SHA for e58a516

• Remove unused deleteEvent channel

  foodprocessor

  committed
  e37f609

  Copy full SHA for e37f609

Commits on Nov 26, 2024

• Use cacheTimeoutMonitor even when timeout is zero.

  Show description for 63f412d
  foodprocessor

  committed
  63f412d

  Copy full SHA for 63f412d

• Do not use CachePurge for eviction, even when timeout is zero.

  Show description for 3e71a0f
  foodprocessor

  committed
  3e71a0f

  Copy full SHA for 3e71a0f

• fixup

  foodprocessor

  committed
  5d2e6af

  Copy full SHA for 5d2e6af

• Merge branch 'zero-timeout-evicts-all' into delete-files-synchronously

  foodprocessor

  committed
  8a6f792

  Copy full SHA for 8a6f792

• Use fileLocks to keep file info coherent

  foodprocessor

  committed
  2b62986

  Copy full SHA for 2b62986

• Merge remote-tracking branch 'origin/main' into delete-files-synchronously

  foodprocessor

  committed
  1704b57

  Copy full SHA for 1704b57

Commits on Nov 27, 2024

• Remove locks in Chmod & FlushFile to avoid deadlock

  foodprocessor

  committed
  77206e8

  Copy full SHA for 77206e8

• Use object paths when locking files in RenameDir.

  foodprocessor

  committed
  383e8bf

  Copy full SHA for 383e8bf

• Close loopback file handles to avoid issues (especially on Windows).

  foodprocessor

  committed
  965676c

  Copy full SHA for 965676c

• Prevent attribute data corruption

  foodprocessor

  committed
  4c77941

  Copy full SHA for 4c77941

• Fix remaining race conditions detected in file cache

  foodprocessor

  committed
  60321b5

  Copy full SHA for 60321b5

• Lock file to protect calls to stat.

  foodprocessor

  committed
  ff15366

  Copy full SHA for ff15366

• Merge branch 'fix-race-conditions' into delete-files-synchronously

  foodprocessor

  committed
  4f3f95a

  Copy full SHA for 4f3f95a

• Make timeout minimum 1s.

  Show description for 7b45c80
  foodprocessor

  committed
  7b45c80

  Copy full SHA for 7b45c80

• Merge branch 'timeout-minimum-1s' into delete-files-synchronously

  foodprocessor

  committed
  f810edf

  Copy full SHA for f810edf

• Reinstate test which was flaky due to a race condition

  foodprocessor

  committed
  bcb288d

  Copy full SHA for bcb288d

• Remove protection from stat call, which is not within the scope of this PR.

  foodprocessor

  committed
  2ea9b61

  Copy full SHA for 2ea9b61

• Merge branch 'fix-race-conditions' into delete-files-synchronously

  foodprocessor

  committed
  74e3769

  Copy full SHA for 74e3769

• Change test config default to default timeout (120s)

  foodprocessor

  committed
  3fe1ede

  Copy full SHA for 3fe1ede

• Slow down test check loops to 100ms

  foodprocessor

  committed
  5b3a6a1

  Copy full SHA for 5b3a6a1

• Add custom configs for eviction tests.

  Show description for 95f6228
  foodprocessor

  committed
  95f6228

  Copy full SHA for 95f6228

• Don't open to prevent eviction in tests (unless testing that mechanic).

  Show description for f5707fb
  foodprocessor

  committed
  f5707fb

  Copy full SHA for f5707fb

Commits on Dec 21, 2024

• Open from cache when no object exists

  foodprocessor

  committed
  0caeb2f

  Copy full SHA for 0caeb2f

• Rename downloadFile to openFileInternal

  foodprocessor

  committed
  16c8290

  Copy full SHA for 16c8290

• openFileInternal runs with flock already locked

  foodprocessor

  committed
  6eb909b

  Copy full SHA for 6eb909b

• Remove redundant code

  foodprocessor

  committed
  787c623

  Copy full SHA for 787c623

• Replace lost flock.Inc

  foodprocessor

  committed
  a5b2e51

  Copy full SHA for a5b2e51

• Add test to verify that OpenFile changes what GetAttr returns when opening a new file

  foodprocessor

  committed
  2d0e64a

  Copy full SHA for 2d0e64a

• Do not use &internal.ObjAttr when you mean nil!

  foodprocessor

  committed
  730c271

  Copy full SHA for 730c271

Commits on Dec 31, 2024

• Merge remote-tracking branch 'main' into delete-files-synchronously

  foodprocessor

  committed
  b0c87be

  Copy full SHA for b0c87be

• Merge branch 'local-files-open-right-away' into delete-files-synchronously

  foodprocessor

  committed
  b3136ef

  Copy full SHA for b3136ef

Commits on Jan 1, 2025

• Add lazy open state in flock, since it affects the whole file's state (not just one handle).

  Show description for 1c83708
  foodprocessor

  committed
  1c83708

  Copy full SHA for 1c83708

• Refactor isDownloadRequired, and use LazyOpen state variable to allow downloading when the file is lazy opened (but not completely opened).

  foodprocessor

  committed
  d59c324

  Copy full SHA for d59c324

• Refactor openFile

  Show description for d9d2845
  foodprocessor

  committed
  d9d2845

  Copy full SHA for d9d2845

• Update file state in CreateFile

  foodprocessor

  committed
  e21dcc1

  Copy full SHA for e21dcc1

• Use O_CREAT flag when testing creation with OpenFile.

  foodprocessor

  committed
  80fee42

  Copy full SHA for 80fee42

• Merge branch 'local-files-open-right-away' into refactor-openFile

  foodprocessor

  committed
  dc7fc99

  Copy full SHA for dc7fc99

• Merge branch 'refactor-openFile' into delete-files-synchronously

  foodprocessor

  committed
  78be394

  Copy full SHA for 78be394

• Update state in DeleteFile

  foodprocessor

  committed
  b0cbc15

  Copy full SHA for b0cbc15

• Update file state in CachePurge (and not speculatively outside of it)

  foodprocessor

  committed
  ffd5aea

  Copy full SHA for ffd5aea

• Improve openFile file state logic

  foodprocessor

  committed
  2ffa0cb

  Copy full SHA for 2ffa0cb

• Protect file state in Close and Flush (and Sync by consequence)

  foodprocessor

  committed
  9f47003

  Copy full SHA for 9f47003

• make flushFileInternal update the file state itself

  foodprocessor

  committed
  094417d

  Copy full SHA for 094417d

• make renameCachedFile protect and update file states

  foodprocessor

  committed
  5e1a000

  Copy full SHA for 5e1a000

Commits on Jan 2, 2025

• When locking more that one file, always go in lexical order to prevent deadlock

  foodprocessor

  committed
  80d659c

  Copy full SHA for 80d659c

• Add TODOs for directory operations

  foodprocessor

  committed
  143e7c4

  Copy full SHA for 143e7c4

• Lock all files before renaming or deleting a whole directory in one operation.

  foodprocessor

  committed
  4841a19

  Copy full SHA for 4841a19

• Merge branch 'delete-files-synchronously' into maintain-file-state

  foodprocessor

  committed
  56a509c

  Copy full SHA for 56a509c

• Make CachePurge update the file state

  foodprocessor

  committed
  d6a3c72

  Copy full SHA for d6a3c72

• Remove file state flags which are never read, and the complexity they caused.

  foodprocessor

  committed
  f712e7f

  Copy full SHA for f712e7f

• Protect file state in GetAttr and Chmod

  foodprocessor

  committed
  ccaca08

  Copy full SHA for ccaca08

• Remove unused flags in platform-specific file cache files

  foodprocessor

  committed
  b519f5b

  Copy full SHA for b519f5b

• Avoid deadlock when flushFileInternal calls Chmod

  foodprocessor

  committed
  1defe41

  Copy full SHA for 1defe41

• Don't use base name to find the object name when WalkDir is recursive

  foodprocessor

  committed
  74ed602

  Copy full SHA for 74ed602

Commits on Jan 7, 2025

• Don't search and lock files in DeleteDir, since it is only called on empty targets

  foodprocessor

  committed
  681b140

  Copy full SHA for 681b140

• Simplify DeleteDir, since the directory being deleted is empty

  foodprocessor

  committed
  c23d36b

  Copy full SHA for c23d36b

• Revert accidental code comment change

  foodprocessor

  committed
  6655269

  Copy full SHA for 6655269

Commits on Jan 11, 2025

• Merge branch 'main' into delete-files-synchronously

  foodprocessor

  committed
  a45a761

  Copy full SHA for a45a761

• Move helper functions to where they are used

  foodprocessor

  committed
  077d979

  Copy full SHA for 077d979

Commits on Jan 14, 2025

• Remove deadlock bug from incorrect branch merge

  foodprocessor

  committed
  0cefa32

  Copy full SHA for 0cefa32

Commits on Jan 15, 2025

• Fix open handle count issue with Rename

  jfantinhardesty

  committed
  64997fd

  Copy full SHA for 64997fd