Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added documentation for MiraiAction #155

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: Added documentation for MiraiAction #155

wants to merge 6 commits into from

Conversation

i-asimkhan
Copy link
Contributor

Description

Added documentation for MiraiAction

Related Issues

Closes #154

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code refactor
  • Build configuration change
  • Documentation
  • Chore

@i-asimkhan i-asimkhan self-assigned this Jun 14, 2023
@i-asimkhan i-asimkhan added the documentation Improvements or additions to documentation label Jun 14, 2023
@i-asimkhan i-asimkhan added this to the v0.4 milestone Jun 14, 2023
@i-asimkhan i-asimkhan marked this pull request as ready for review June 14, 2023 10:36
@i-asimkhan i-asimkhan requested a review from divyanshub024 June 14, 2023 10:36
@i-asimkhan i-asimkhan removed this from the v0.4 milestone Jun 15, 2023
@RodolfoSilva
Copy link
Contributor

@i-asimkhan This will change a little bit when the #169 was approved. In the #169 the class MiraiAction was replaced by MiraiActionParser.

RodolfoSilva
RodolfoSilva suggested changes Jul 15, 2023
View reviewed changes
Copy link
Contributor

@RodolfoSilva RodolfoSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the component documentation, I think we could have a dedicated folder to store all the actions documentation.

docs/docs/basics/actions.md Outdated Show resolved Hide resolved
docs/docs/basics/actions.md Outdated Show resolved Hide resolved
docs/docs/basics/actions.md Outdated Show resolved Hide resolved
docs/docs/basics/actions.md Outdated Show resolved Hide resolved
@i-asimkhan i-asimkhan requested a review from RodolfoSilva July 20, 2023 10:56
@i-asimkhan
Copy link
Contributor Author

@i-asimkhan This will change a little bit when the #169 was approved. In the #169 the class MiraiAction was replaced by MiraiActionParser.

Yeah, will keep it till we merge them.

@RodolfoSilva
Copy link
Contributor

@i-asimkhan This will change a little bit when the #169 was approved. In the #169 the class MiraiAction was replaced by MiraiActionParser.

Yeah, will keep it till we merge them.

Ok 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyanshub024 divyanshub024 Awaiting requested review from divyanshub024

@RodolfoSilva RodolfoSilva Awaiting requested review from RodolfoSilva

At least 1 approving review is required to merge this pull request.

Assignees

@i-asimkhan i-asimkhan

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: Add docs for Mirai Action
2 participants
@i-asimkhan @RodolfoSilva