Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

Proposing some useful defaults #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

saif-ellafi
Copy link

@saif-ellafi saif-ellafi commented Jan 23, 2020

Hi,

Hope this is not very biased, but having two nodes by defaults makes much more sense for an initial state. Also, added three yarn settings that are useful to do any kind of experimentation by default.

I added a little bit "more" than yarn defaults as a base, but usually to get anything done with spark we still need to pump up those minimums (default is 1024M)

@saif-ellafi saif-ellafi requested a review from robvadai January 23, 2020 12:14
- HADOOP_NAMENODE_HOST=hadoop-namenode
volumes:
- ./data-slave2:/data
- ./slaves-config:/config:ro
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ro addition is good, I guess we can add it to slave1 as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does have it already

@saif-ellafi
Copy link
Author

@robvadai do you know why when I call docker-compose it does not put my yarn-site changes on the image when loading it?

@robvadai
Copy link
Member

robvadai commented Feb 2, 2020

hi @saif-ellafi , the image needs to be rebuilt and docker compose just uses the latest image tag. To test you need to build the image yourself locally. You can use the build-docker-image.sh script, just run it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants