Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locator plugins #921

Closed
wants to merge 7 commits into from
Closed

Conversation

ortoniKC
Copy link

@ortoniKC ortoniKC commented Jan 6, 2020

Thanks for contributing to the Selenium IDE!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@corevo
Copy link
Member

corevo commented Jan 6, 2020

Duplicate of #228
There is a reason I didn't accept my own PR, it's because I couldn't figure a way to record new locators through plugins, only to play them back.

You are more than welcome to fix my PR, and add that, if you find a way to do it, but as long as this PR is the exact same as #228 I will have to close it.

@corevo corevo closed this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants