added some missing logging in RestApi [see #127]

SemsProject · Oct 8, 2015 · 3edeede · 3edeede
1 parent 30cd404
commit 3edeede
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/src/main/java/de/unirostock/sems/cbarchive/web/rest/RestApi.java b/src/main/java/de/unirostock/sems/cbarchive/web/rest/RestApi.java
@@ -367,8 +367,10 @@ public Response deleteWorkspace( @CookieParam(Fields.COOKIE_PATH) String userPat
 				history.getRecentWorkspaces().add( user.getWorkspace() );
 			history.setCurrentWorkspace( user.getWorkspaceId() );
 
-			if( workspaceId == null || workspaceId.isEmpty() )
+			if( workspaceId == null || workspaceId.isEmpty() ) {
+				LOGGER.error("No workspace id was provided for deletion");
 				return buildErrorResponse(400, user, "No workspace ID provided");
+			}
 
 			// removes workspace
 			history.removeWorkspaceFromHistory(workspaceId);
@@ -433,8 +435,10 @@ public Response updateOwnVcard( @CookieParam(Fields.COOKIE_PATH) String userPath
 			user.setData(data);
 			return buildResponse(200, user).entity(user.getData()).build();
 		}
-		else
+		else {
+			LOGGER.warn("User ", user.getWorkspaceId(), " has provided insufficient information to update vCard");
 			return buildErrorResponse(400, user, "insufficient user information");
+		}
 	}
 
 	// --------------------------------------------------------------------------------
@@ -1077,8 +1081,10 @@ public Response deleteArchiveEntry( @PathParam("archive_id") String archiveId, @
 
 				if( result )
 					return buildResponse(200, user).entity("ok").build();
-				else
+				else {
+					LOGGER.error("Cannot move meta description for entry ", entryId, " in Archive ", archiveId, " in Workspace ", user.getWorkspaceId());
 					return buildErrorResponse(500, user, "Cannot remove meta description");
+				}
 			} catch (TransformerException e) {
 				LOGGER.error(e, MessageFormat.format("Cannot pack archive {0} entries in WorkingDir {1}", archiveId, user.getWorkingDir()) );
 				return buildErrorResponse( 500, user, "Cannot delete meta info", "Cannot pack archive " + archiveId + " entries in WorkingDir " + user.getWorkingDir().toString(), e.getMessage() );
@@ -1369,8 +1375,10 @@ public Response deleteMetaObject( @PathParam("archive_id") String archiveId, @Pa
 
 				if( result )
 					return buildResponse(200, user).entity("ok").build();
-				else
+				else {
+					LOGGER.error("Cannot remove meta description for entry ", entryId, " in Archive ", archiveId, " in Workspace ", user.getWorkspaceId());
 					return buildErrorResponse(500, user, "Cannot remove meta description");
+				}
 			} catch (TransformerException e) {
 				LOGGER.error(e, MessageFormat.format("Cannot pack archive {0} entries in WorkingDir {1}", archiveId, user.getWorkingDir()) );
 				return buildErrorResponse( 500, user, "Cannot delete meta info", "Cannot pack archive " + archiveId + " entries in WorkingDir " + user.getWorkingDir().toString(), e.getMessage() );