Update/ion kit 1.0.0 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpp/src/tutorial1_display.cpp
Outdated
| @@ -133,7 +98,6 @@ int main(int argc, char *argv[]) | |||
| int ret = video<uint16_t>(width, height, pixelformat, num_device); | |||
| } | |||
|
|
|||
|
|
|||
| }catch(std::exception& e){ | |||
There was a problem hiding this comment.
It should catch ion::Error additionally to std::exception.
There was a problem hiding this comment.
fixed in 87d09cf
cpp/src/tutorial1_display.cpp
Outdated
| // JIT compilation and execution of pipelines with Builder. | ||
| try { | ||
| b.run(pm); | ||
| b.run(); | ||
| }catch(std::exception& e){ |
There was a problem hiding this comment.
We can delete try-catch from here and delegate to outermost try-catch block.
There was a problem hiding this comment.
fixed in a85a0a5
python/tutorial1_display.py
Outdated
| # running the builder | ||
| builder.run(port_map) | ||
| builder.run() | ||
| output_bytes = outputs[0].read(output_byte_size) |
There was a problem hiding this comment.
read is no longer needed. You can create ion.Buffer passing numpy array (Buffer(array=numpy_array)) and you can access data through numpy array without ion.Buffer.read/write operation
There was a problem hiding this comment.
fixed in 24b9ed0
…sing-dev-tutorials into update/ion-kit-1.0.0
xinyuli1204
reviewed
Jan 16, 2024
python/tutorial1_display.py
Outdated
| port_map.set_buffer(gain_p, gains) | ||
| port_map.set_buffer(exposuretime_p, exposures) | ||
| port_map.set_buffer_array(output_p, outputs) | ||
| output_p[0].bind(outputs[0]) |
There was a problem hiding this comment.
after pull fixstars/ion-kit#207
you can use output_p.bind(outputs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tutorial code for ion-kit 1.0.0
C++
Python
Note: Python binding issues are still under fixing at (fixstars/ion-kit#206 and fixstars/ion-kit#205)
Added tutorial code for ion-kit 1.0.0
C++
Python