Upgrade slf4j wrapper #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilZ-cwm6
commented
Jun 30, 2022
•
PhilZ-cwm6
commented
- Upgrade slf4j wrapper to support all current slf4j formatting options for both compatibility with third party libraries (jcifs-nlg) and for performance (accept formatting string with {})
- Update zip4j to 2.11.1:
- use stock upstream zip4j lib
- fixes upstream zip4j vulnerabilities
- drop un-needed SMBSync3 compression methods
Upgrade slf4j wrapper to support all current slf4j formatting options for both compatibility with third party libraries (jcifs-nlg) and for performance (accept formatting string with {})
- use stock upstream zip4j lib - fixes upstream zip4j vulnerabilities - drop un-needed SMBSync3 compression methods
When creating a Zip Sync Task, when we browse for existing files and we enter a zip file name, browsing further into an empty directory disables the Ok button even if the filename is properly set
On app start and on EditSyncTasks, SafManager was causing NPE and app/system crash to get app specific directory Note that currently the method result is not used in code as app specific directory is hardcoded for now
PhilZ-cwm6
force-pushed
the
patch_upstream
branch
from
dff7b27 to
16910c0
Compare
Do not use hard coded references like "/storage/emulated/0". Use built in Android methods to get relevant storage path. This ensures a better compatibility across devices with different storage path standard
On a few devices, there is an implementation bug for secondary external storage (removable sdcard) causing getExternalFilesDirs() method to only return the path for primary external storage (internal non removable storage /Storage/emulated/0) This includes a few Lenovo devices and emulator Pixel devices for APIs 26 and 27 This caused getAppSpecificDirectory() to return null for external removable sdcard path that is now properly checked for on app start
…types - Restore original upstream custom list preference for non compressed file types - Fix screen rotation did not properly preserve Ok button state - Add missing resources for edit compress file type dialogs - Fix compression file types list sorting was only applied in adapter and not persisted in saved preferences - Fix when editing file type entries in list, they were not sorted when back to the list view
- Support custom title dialog in ListEditPreference - Remove unused deprecated method in ListEditPreference
For custom list preference (non compressed file types selection): - add option to undo delete entry - when list is modified, Ok button will only be enabled if the final resulting list is different from the original one - on screen rotation and activity killed, properly preserve all the custom preference list dialogs state
- Upgrade all tools and plugins to latest releases - Target SDK 33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.