Add ucsf partner logo #1307
Merged
Add ucsf partner logo #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 17, 2023 15:46
…estyle CSS/JSX to better fit all the logos
richardxia
approved these changes
Oct 22, 2023
| @@ -154,17 +154,17 @@ export const LinkSf = () => ( | |||
| </li> | |||
| <li> | |||
| <a href="http://evictiondefense.org/" rel="noopener"> | |||
| <img src={EDCLogo} alt="WeWork" /> | |||
| <img src={EDCLogo} alt="Eviction Defense Collaborative" /> | |||
There was a problem hiding this comment.
Thanks for fixing the copy paste issues with the alt text everywhere!
Co-authored-by: Richard Xia <richardxia@richardxia.com>
…hSF/askdarcel-web into add-ucsf-partner-logo
Thanks for reviewing! I've added your suggested changes, and everything looks better. Good catch noticing the effects of removing the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made updates to the home page partners. These include markup/CSS changes for the list of logos. Adding that extra logo causes them to wrap to the next line, which made them look awkward with our current setup.
I also added the logo to the SFSG about page as well as the LinkSF page. I'm not exactly sure if we need to keep the LinkSF page updated or even include the UCSF logo there, but it contains our other logos, so I added it for the time being. I'm not sure we get much traffic on LinkSF as it is, anyhow.
I think the UI that we currently have is not perfect, and it can look awkward on smaller screens, but maybe we should wait until our exec discussion before perfecting the logo UI.
