Merge pull request #260 from Shopify/tra0x/fix-cloudflare-normalization

Fix Changeset normalization

CHANGELOG.md

@@ -1,5 +1,8 @@
 # CHANGELOG
 
+## 8.0.2
+- Fix Changesets to be case-insensitive
+
 ## 8.0.1
 - Fix Cloudflare provider to handle paginated returns from API
 

lib/record_store/changeset.rb

@@ -55,8 +55,8 @@ def build_from(provider:, zone:, all: false)
     end
 
     def initialize(current_records: [], desired_records: [], provider:, zone:)
-      @current_records = Set.new(current_records)
-      @desired_records = Set.new(desired_records)
+      @current_records = Set.new(normalize_records(current_records))
+      @desired_records = Set.new(normalize_records(desired_records))
       @provider = provider
       @zone = zone
 
@@ -114,5 +114,18 @@ def build_changeset
         end
       end
     end
+
+    def normalize_records(records)
+      records.map do |record|
+        record.dup.tap do |r|
+          r.fqdn = r.fqdn.downcase
+          r.rdata.each do |key, value|
+            next if key == :txtdata
+
+            r.send("#{key}=", value.downcase) if value.is_a?(String)
+          end
+        end
+      end
+    end
   end
 end

lib/record_store/version.rb

@@ -1,3 +1,3 @@
 module RecordStore
-  VERSION = '8.0.1'.freeze
+  VERSION = '8.0.2'.freeze
 end