Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiEPIC Version check, layout_diff #227

Merged
merged 5 commits into from
Nov 4, 2024
Merged

SiEPIC Version check, layout_diff #227

merged 5 commits into from
Nov 4, 2024

Conversation

lukasc-ubc
Copy link
Member

No description provided.

@mustafacc

I think it would be nice to add an automated check when SiEPIC-Tools (and also the PDKs) are loaded.  This takes 0.2 s.  I tried to use concurrent.futures, but it doesn't seem to speed things up.
Compare the difference between layouts.
Useful for blackbox replacement double-checking.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.98165% with 24 lines in your changes missing coverage. Please review.

Project coverage is 22.00%. Comparing base (d2a5658) to head (f2cb25c).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
klayout_dot_config/python/SiEPIC/scripts.py 72.60% 20 Missing ⚠️
klayout_dot_config/python/SiEPIC/__init__.py 77.77% 2 Missing ⚠️
...ig/python/SiEPIC/tests/test_scripts_layout_diff.py 92.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   21.46%   22.00%   +0.53%     
==========================================
  Files          45       46       +1     
  Lines       11217    11324     +107     
==========================================
+ Hits         2408     2492      +84     
- Misses       8809     8832      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukasc-ubc lukasc-ubc merged commit e150999 into master Nov 4, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants