Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trace-details): frontend changes for trace details #6905

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Jan 22, 2025

Summary

Related Issues / PR's

contributes to - #6132

Screenshots

NA

Affected Areas and Manually Tested Areas


Important

Introduces a new frontend feature for trace details with enhanced visualization, new components, and API integrations.

  • Behavior:
    • New TraceDetailV2 page added, replacing TraceDetail in pageComponents.ts.
    • Introduces TraceFlamegraph and TraceWaterfall components for detailed trace visualization.
    • Adds error handling and no data states in TraceFlamegraphStates and TraceWaterfallStates.
  • API:
    • Adds getTraceFlamegraph and getTraceV2 functions in getTraceFlamegraph.tsx and getTraceV2.tsx.
    • Introduces hooks useGetTraceFlamegraph and useGetTraceV2 for API data fetching.
  • Components:
    • Adds DetailsDrawer, TableV3, and AttributesTable components for UI enhancements.
    • Implements Success, Error, and NoData components for state management in trace visualization.
  • Styles:
    • New styles added for TraceDetailV2, TraceFlamegraph, and TraceWaterfall components.
    • Updates to existing styles for consistency and theme support.
  • Misc:
    • Updates reactQueryKeys.ts with new query keys for trace data.
    • Adds new types in getTraceFlamegraph.ts and getTraceV2.ts for API responses.

This description was created by Ellipsis for 7eb044d. It will automatically update as commits are pushed.

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Jan 22, 2025
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to aaa4529 in 1 minute and 57 seconds

More details
  • Looked at 4290 lines of code in 47 files
  • Skipped 3 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/pages/TraceDetail/TraceDetail.styles.scss:17
  • Draft comment:
    Avoid using hardcoded color values like #c0c1c3. Use design tokens or predefined color constants instead. This issue is also present on line 30.
  • Reason this comment was not posted:
    Marked as duplicate.
2. frontend/src/pages/TraceDetailV2/NoData/NoData.styles.scss:22
  • Draft comment:
    Avoid using hardcoded color values like #c0c1c3. Use design tokens or predefined color constants instead. This issue is also present on line 30.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_nIGb0AKprzZ1c5Y5


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 7eb044d in 44 seconds

More details
  • Looked at 68 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/container/PaginatedTraceFlamegraph/constants.ts:6
  • Draft comment:
    Typo in 'FETCHING_WTIH_OLD_DATA_PRESENT'. It should be 'FETCHING_WITH_OLD_DATA_PRESENT'. This typo is also present in TraceWaterfallStates in TraceWaterfall/constants.ts.
  • Reason this comment was not posted:
    Comment was on unchanged code.
2. frontend/src/hooks/trace/useGetTraceFlamegraph.tsx:13
  • Draft comment:
    The return type UseLicense is misleading. Consider renaming it to something more appropriate like UseTraceFlamegraph. This also applies to useGetTraceV2.tsx.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_zwLOyMcuHqPAqqiq


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant