-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(trace-details): frontend changes for trace details #6905
base: main
Are you sure you want to change the base?
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to aaa4529 in 1 minute and 57 seconds
More details
- Looked at
4290
lines of code in47
files - Skipped
3
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. frontend/src/pages/TraceDetail/TraceDetail.styles.scss:17
- Draft comment:
Avoid using hardcoded color values like#c0c1c3
. Use design tokens or predefined color constants instead. This issue is also present on line 30. - Reason this comment was not posted:
Marked as duplicate.
2. frontend/src/pages/TraceDetailV2/NoData/NoData.styles.scss:22
- Draft comment:
Avoid using hardcoded color values like#c0c1c3
. Use design tokens or predefined color constants instead. This issue is also present on line 30. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_nIGb0AKprzZ1c5Y5
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
frontend/src/container/TraceWaterfall/TraceWaterfallStates/Success/Success.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 7eb044d in 44 seconds
More details
- Looked at
68
lines of code in5
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. frontend/src/container/PaginatedTraceFlamegraph/constants.ts:6
- Draft comment:
Typo in 'FETCHING_WTIH_OLD_DATA_PRESENT'. It should be 'FETCHING_WITH_OLD_DATA_PRESENT'. This typo is also present inTraceWaterfallStates
inTraceWaterfall/constants.ts
. - Reason this comment was not posted:
Comment was on unchanged code.
2. frontend/src/hooks/trace/useGetTraceFlamegraph.tsx:13
- Draft comment:
The return typeUseLicense
is misleading. Consider renaming it to something more appropriate likeUseTraceFlamegraph
. This also applies touseGetTraceV2.tsx
. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_zwLOyMcuHqPAqqiq
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Summary
Related Issues / PR's
contributes to - #6132
Screenshots
NA
Affected Areas and Manually Tested Areas
Important
Introduces a new frontend feature for trace details with enhanced visualization, new components, and API integrations.
TraceDetailV2
page added, replacingTraceDetail
inpageComponents.ts
.TraceFlamegraph
andTraceWaterfall
components for detailed trace visualization.TraceFlamegraphStates
andTraceWaterfallStates
.getTraceFlamegraph
andgetTraceV2
functions ingetTraceFlamegraph.tsx
andgetTraceV2.tsx
.useGetTraceFlamegraph
anduseGetTraceV2
for API data fetching.DetailsDrawer
,TableV3
, andAttributesTable
components for UI enhancements.Success
,Error
, andNoData
components for state management in trace visualization.TraceDetailV2
,TraceFlamegraph
, andTraceWaterfall
components.reactQueryKeys.ts
with new query keys for trace data.getTraceFlamegraph.ts
andgetTraceV2.ts
for API responses.This description was created by for 7eb044d. It will automatically update as commits are pushed.