Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade test_logsource.py #4932

Closed
wants to merge 4 commits into from
Closed

Conversation

frack113
Copy link
Member

Summary of the Pull Request

Upgrade test_logsource.py to pySigma

Changelog

chore: Upgrade test_logsource.py to pySigma
fix: HackTool - LaZagne Execution - fix logsource

Example Log Event

Fixed Issues

SigmaHQ Rule Creation Conventions

  • If your PR adds new rules, please consider following and applying these conventions

@frack113 frack113 requested a review from nasbench July 25, 2024 17:40
@github-actions github-actions bot added Rules Windows Pull request add/update windows related rules Maintenance Related to additions and update of the repository features labels Jul 25, 2024
@nasbench nasbench added the Work In Progress Some changes are needed label Jul 29, 2024
Copy link
Member

@nasbench nasbench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain the changes you've made to the script

tests/logsource.json Outdated Show resolved Hide resolved
@nasbench nasbench added the Author Input Required changes the require information from original author of the rules label Jul 31, 2024
@nasbench nasbench marked this pull request as draft July 31, 2024 08:23
@nasbench nasbench removed the Author Input Required changes the require information from original author of the rules label Aug 1, 2024
@nasbench nasbench self-assigned this Aug 3, 2024
@nasbench
Copy link
Member

nasbench commented Sep 2, 2024

Closing this in favor of new SigmaHQ/pySigma-validators-sigmaHQ#16 validator

@nasbench nasbench closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Related to additions and update of the repository features Rules Windows Pull request add/update windows related rules Work In Progress Some changes are needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants