[FIX] sale_triple_discount: restore original discount field's precision by using change_digit function #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tafaRU
changed the title
fredzamoabg
suggested changes
Aug 3, 2021
| @@ -113,7 +113,7 @@ def triple_discount_preprocess(self): | |||
| # more digits than allowed from field's precision, | |||
| # so let's increase it just for saving it correctly in cache | |||
| discount_field = self._fields['discount'] | |||
| discount_original_digits = discount_field._digits | |||
| discount_original_digits = dp.get_precision("Discount")(self.env.cr) | |||
There was a problem hiding this comment.
please see SimoRubi/account-invoicing#1 (comment)
…ion in order to avoid to have always (16, 10) as precision in case of any errors.
tafaRU
force-pushed
the
12.0-fix-sale_triple_discount-round_discount_digits
branch
from
f5020b6 to
094fb5b
Compare
fredzamoabg
approved these changes
Aug 4, 2021
|
I'm proposing this PR (paired with SimoRubi/account-invoicing#1) to fix a strange behaviour that happend to one of our customers which is using OCA#1618 + OCA/account-invoicing#876
In this way the attribute By using this PR (paired with SimoRubi/account-invoicing#1) seems the problem was solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use change_digit function to restore original discount field's precision in order to avoid to have always (16, 10) as precision in case of any errors.