initial commit #59
Open
initial commit #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DmitrySazonov да, в тестах действительно были ошибки. Я сейчас поправил их в |
|
@SimonHarmonicMinor смерджился Сазонов Дмитрий Иванович dmsazonov@gmail.com |
|
@DmitrySazonov смержись еще раз, я убрал этап проверки хэша |
|
@SimonHarmonicMinor смерджился |
|
@SimonHarmonicMinor , еще добавлю, что было бы круто, если бы изначально в pom был добавлен pitest. Доп тесты не писал, но с pitest можно было бы упороться в покрытие 100% ) |
|
@DmitrySazonov я думаю, что это уже перебор для тестового задания) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SimonHarmonicMinor
Сазонов Дмитрий Иванович dmsazonov@gmail.com
Часть тестов были некорректны, поправил с учетом логики протокола из readme.