Merge pull request #226 from SimonStnn/refactor/new-account-creation

Don't set a default username

src/background/background.ts

@@ -78,7 +78,7 @@ const updateBadgeColors = () => {
     let localUser = await storage.sync.get('user');
     // If the user is not in the local storage, get a new user from the remote
     if (!localUser) {
-      const usr = await remote.NewUser('Anonymous');
+      const usr = await remote.NewUser();
       await storage.sync.set('token', usr.token);
       localUser = usr;
     }

src/balloons/default.ts

@@ -57,13 +57,13 @@ export default class Default extends Balloon {
   /**
    * The image element for the balloon image.
    */
-  protected readonly balloonImage: HTMLImageElement =
+  public readonly balloonImage: HTMLImageElement =
     document.createElement('img');
 
   /**
    * The sound element for the pop sound.
    */
-  private readonly popSound: HTMLAudioElement = new Audio();
+  public readonly popSound: HTMLAudioElement = new Audio();
 
   /**
    * The URL of the balloon image.

src/const.ts

@@ -31,7 +31,7 @@ export const initalConfig: _initialConfig = {
 
 export type User = {
   id: string;
-  username: string;
+  username?: string;
   email?: string;
   count: number;
   updatedAt: string;

src/popup/components/forms/UpdateUser.tsx

@@ -47,7 +47,7 @@ export default () => {
     const loadUser = async () => {
       const storedUser = await storage.sync.get('user');
       setUser(storedUser);
-      form.setValue('username', storedUser.username);
+      form.setValue('username', storedUser.username || '');
       form.setValue('email', storedUser.email || '');
     };
 
@@ -56,7 +56,10 @@ export default () => {
 
   const onSubmit = async ({ username, email }: z.infer<typeof formSchema>) => {
     if (username === user?.username && email === user?.email) return;
-    const newUser = await remote.putUser({ username, email });
+    const newUser = await remote.putUser({
+      username: username !== '' ? username : undefined,
+      email: email !== '' ? email : undefined,
+    });
     setUser(newUser);
     await storage.sync.set('user', newUser);
   };

src/remote.ts

@@ -93,7 +93,7 @@ class BackendAPI {
     );
   }
 
-  public async NewUser(username: string, email?: string) {
+  public async NewUser(username?: string, email?: string) {
     return await this.request<
       Prettify<{ token: string } & RemoteResponse['user']>
     >('POST', '/user/new', {