Addition of the Ghost balloon #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
SimonStnn
reviewed
Oct 1, 2024
src/balloons/fast.ts
Outdated
| @@ -12,7 +12,7 @@ export default class Fast extends Default { | |||
| return { | |||
| ...super.options, | |||
| imageUrl: 'balloon.svg', | |||
| riseDuration: [5000, 7500], | |||
| riseDuration: [2000, 4000], | |||
There was a problem hiding this comment.
This is way to fast. Has this even been tested? It is not realistic for a user to be able to pop this. Keep the values at [4000, 6500].
SimonStnn
reviewed
Oct 1, 2024
resources/balloons/ghost/balloon.svg
Outdated
Comment on lines
6
to
8
| 0% { opacity: 0.1; } | ||
| 50% { opacity: 0.7; } | ||
| 100% { opacity: 0.1; } |
SimonStnn
reviewed
Oct 1, 2024
resources/balloons/ghost/balloon.svg
Outdated
|
|
||
| svg { | ||
| animation: fade 4s infinite; | ||
| }QA |
There was a problem hiding this comment.
Was probably on accident
SimonStnn
reviewed
Oct 1, 2024
src/balloons/ghost.ts
Outdated
Comment on lines
15
to
16
| swingDuration: [3, 4], | ||
| }; |
There was a problem hiding this comment.
Make the swing offset larger for the gost balloon. Could be more fitting.
There was a problem hiding this comment.
offset is now 25
SimonStnn
requested changes
Oct 1, 2024
SimonStnn
reviewed
Oct 1, 2024
resources/balloons/ghost/balloon.svg
Outdated
| 100% { opacity: 0.1; } | ||
| } | ||
|
|
||
| svg { |
- more comments on ghost balloon.svg - option changes to ghost.ts
SimonStnn
requested changes
Oct 2, 2024
Co-authored-by: SimonStnn simon.stijnen.23@gmail.com
SimonStnn
requested changes
Oct 20, 2024
src/balloons/ghost.ts
Outdated
| imageUrl: 'balloon.svg', | ||
| riseDuration: [15000, 20000], | ||
| swingDuration: [3, 4], | ||
| swingOffset: 25, |
There was a problem hiding this comment.
Make the swingOffset bigger.
Suggested change
| swingOffset: 25, | |
| swingOffset: 25, |
src/balloons/ghost.ts
Outdated
| return { | ||
| ...super.options, | ||
| imageUrl: 'balloon.svg', | ||
| riseDuration: [15000, 20000], |
There was a problem hiding this comment.
The rise duration can be a bit longer
Suggested change
| riseDuration: [15000, 20000], | |
| riseDuration: [18000, 21000], |
- riseDuration changed to [20000,40000]
SimonStnn
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.