-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build with Cl and C++20 #368
Open
jorisv
wants to merge
6
commits into
Simple-Robotics:devel
Choose a base branch
from
jorisv:topic/fix-cl-build
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @jorisv, thanks a lot for the fix. Just curious, how is this related to C++20? |
Hello @alxbilger, It's maybe related to some C++20 specific branch in our code base. Code like this one can maybe trigger this issue: #ifdef VEG_WITH_CXX20_SUPPORT
#define VEG_CPP20(...) __VA_ARGS__
#else
#define VEG_CPP20(...)
#endif I will not dig into the root cause since the fix allow to use the |
I see. Thanks for the clarification |
jorisv
force-pushed
the
topic/fix-cl-build
branch
from
January 24, 2025 13:09
c1a4c79
to
4faceb6
Compare
jorisv
force-pushed
the
topic/fix-cl-build
branch
from
January 24, 2025 15:28
16cc180
to
a383d12
Compare
fabinsch
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #367
Cl compiler doesn't expand
__VA_ARGS__
like clang or gcc. It's well documented but hard to catch.@aescande have introduce the
__VEG_PP_ID
macro to overcome this issue without activating the /Zc:preprocessor compiler flags.TODO