Aliases - add support for aliases by MC keys #7492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I only changed it so I could visually see where it as going
Forgot the copper trapdoor was new
- also test to make sure no conflicts with blockdata
Efnilite
approved these changes
Jan 21, 2025
Efnilite
added
the
enhancement
cheeezburga
approved these changes
Jan 25, 2025
cheeezburga
added
the
feature-ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add support for using Minecraft keys to get ItemTypes.
I have attempted this before and always somehow created a bug. By gosh I think I finally got it.
Many MANY people have been asking for this over the years (myself included).
A lot of users are used to Minecraft keys due to commands, datapacks, etc, and this may help them in some cases.
With the addition of the RegistryClassInfo I added that supports Minecraft names, it seems fitting to allow it for item aliases as well.
I added a regression test to make sure this doesn't break anything, including normal and script based aliases.
Target Minecraft Versions: any
Requirements: none
Related Issues: #5166