-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventValues - add an option to use changers #7512
base: dev/feature
Are you sure you want to change the base?
EventValues - add an option to use changers #7512
Conversation
Showcase: on consume:
send "Before: %event-item%"
set event-item to 1 of stick
send "After: %event-item%" Screen.Recording.2025-01-22.at.10.42.50.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself seems fine. I'm wondering how this might interact with existing event value expressions, such as https://github.com/SkriptLang/Skript/blob/master/src/main/java/ch/njol/skript/expressions/ExprItem.java. It appears there would be a difference with set the item to ...
and set the event-item to ...
src/main/java/org/skriptlang/skript/lang/converter/EventConverter.java
Outdated
Show resolved
Hide resolved
I'll be honest, this didn't cross my mind. Ill test and get back to you. EDIT: |
src/main/java/org/skriptlang/skript/bukkit/event/EventConverter.java
Outdated
Show resolved
Hide resolved
- As per pickle's request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Room for adding JUnit tests? (Expecting to exceed beyond the limit of the sky)
Description
This PR aims to add the ability to have changers for event-values.
NOTES:
event-item
in the consume event. TESTED HEAVILY with both a single value and array. Works nicely.Target Minecraft Versions: any
Requirements: none
Related Issues: #7485