Remove unused setting #1144
Merged
Remove unused setting #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthegreat1
requested changes
Jan 22, 2025
| @@ -61,7 +61,5 @@ public class ChatConfig { | |||
| public static class ChatRuleConfig { | |||
| @SerialEntry | |||
| public int announcementLength = 60; | |||
There was a problem hiding this comment.
Just deprecate the config options to prevent future conflicts.
Suggested change
| public int announcementLength = 60; | |
| public int announcementLength = 60; | |
| @Deprecated | |
| @SerialEntry | |
| public int announcementScale = 3; |
LifeIsAParadox
added
changes requested
LifeIsAParadox
added
reviews needed
kevinthegreat1
approved these changes
Jan 23, 2025
LifeIsAParadox
added
merge me please
kevinthegreat1
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting is not used any more. So just confusing being in the config