Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support http basic auth #29

Merged
merged 1 commit into from
Sep 30, 2024
Merged

feat: support http basic auth #29

merged 1 commit into from
Sep 30, 2024

Conversation

jimirocks
Copy link
Contributor

Resolves #26

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.98%. Comparing base (efbdaa9) to head (3b03af3).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/commonMain/kotlin/ktor/KtorHttpLoxoneClient.kt 70.00% 2 Missing and 1 partial ⚠️
src/commonMain/kotlin/LoxoneAuth.kt 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   75.50%   75.98%   +0.47%     
==========================================
  Files          26       27       +1     
  Lines         396      408      +12     
  Branches       77       80       +3     
==========================================
+ Hits          299      310      +11     
  Misses         46       46              
- Partials       51       52       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimirocks jimirocks merged commit 07cbeb4 into master Sep 30, 2024
7 checks passed
@jimirocks jimirocks deleted the jimi/basic branch September 30, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support basic auth
2 participants