Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule title #22

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Schedule title #22

merged 5 commits into from
Sep 2, 2024

Conversation

olekszczepanowski
Copy link
Member

Można zmieniać tytuły planów. Jest naprawiony navbar ktory na obu widokach (createplan, plans) wyglada tak samo teraz i jest wycentrowany odpowiednio. Input planu imo siedzi ladnie, nic ladniejszego nie wpadlo mi do glowy. Trzeba bedzie naprawic jeszcze footery, moge sie tym tez zajac potem, bo jest tam troche najebane dziwnych rzeczy.

Copy link
Member

@Rei-x Rei-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MEGA ROBOTA OLO


export const SolvroLogo = () => {
return (
<a href="https://planer.solvro.pl/" className="inline-block">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

raczej powinniśmy dać tu po prostu, żeby też działalo lokalnie

Suggested change
<a href="https://planer.solvro.pl/" className="inline-block">
<Link href="/" className="inline-block">

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wiem, że ty tylko do pliku to wyrzuciłeś, ale jak możesz to popraw 😭

alt="Logo Koła Naukowego Solvro"
width={50}
height={50}
className="cursor-pointer"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cursor-pointer raczej na linku powinien być?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nie tykalem tego i wyrzucilem do osobnego pliku

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wieem, ale jak możesz to popraw i wrzuć to na Link

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g

Comment on lines 297 to 313
<div className="flex items-center justify-center rounded-xl bg-mainbutton2 p-1.5 text-lg font-semibold md:text-3xl">
<input
type="text"
value={plan.name}
onChange={(e) => {
changePlanName(e.target.value);
}}
className={`w-full truncate border-mainbutton5 bg-transparent outline-none duration-100 ease-in-out before:transition-all ${
isEditing ? "border-b-2 font-normal" : " "
}`}
disabled={!isEditing}
/>
<CiEdit
className="ml-2 transform cursor-pointer transition-transform hover:scale-110 active:scale-90"
onClick={handleEditClick}
/>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zrób z tego formularz, żeby też przy kliknięciu enterem nazwa się zapisywała

Comment on lines 304 to 306
className={`w-full truncate border-mainbutton5 bg-transparent outline-none duration-100 ease-in-out before:transition-all ${
isEditing ? "border-b-2 font-normal" : " "
}`}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tutaj zapraszam do uzycia cn z shadcn'a do zrobienia isEditing

Comment on lines 309 to 312
<CiEdit
className="ml-2 transform cursor-pointer transition-transform hover:scale-110 active:scale-90"
onClick={handleEditClick}
/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i też tbh, przy edytowaniu fajnie jakby to się na jakiś checkmark zamieniało?

w sensie
nie da się edytować -> przycisk ten CiEdit
da się edytować -> jakiś checkmark co oznacza zapisanie

i też tbh, zrobiłbym to jako button z shadcn'a

https://ui.shadcn.com/docs/components/button#icon

@Rei-x Rei-x enabled auto-merge (rebase) September 2, 2024 10:16
@Rei-x Rei-x disabled auto-merge September 2, 2024 10:17
@Rei-x Rei-x merged commit a5b7382 into main Sep 2, 2024
1 check passed
@Rei-x Rei-x deleted the schedule-title branch September 2, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants