-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schedule title #22
Schedule title #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MEGA ROBOTA OLO
src/components/SolvroLogo.tsx
Outdated
|
||
export const SolvroLogo = () => { | ||
return ( | ||
<a href="https://planer.solvro.pl/" className="inline-block"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raczej powinniśmy dać tu po prostu, żeby też działalo lokalnie
<a href="https://planer.solvro.pl/" className="inline-block"> | |
<Link href="/" className="inline-block"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wiem, że ty tylko do pliku to wyrzuciłeś, ale jak możesz to popraw 😭
src/components/SolvroLogo.tsx
Outdated
alt="Logo Koła Naukowego Solvro" | ||
width={50} | ||
height={50} | ||
className="cursor-pointer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cursor-pointer raczej na linku powinien być?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nie tykalem tego i wyrzucilem do osobnego pliku
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wieem, ale jak możesz to popraw i wrzuć to na Link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
g
src/pages/createplan/[id].tsx
Outdated
<div className="flex items-center justify-center rounded-xl bg-mainbutton2 p-1.5 text-lg font-semibold md:text-3xl"> | ||
<input | ||
type="text" | ||
value={plan.name} | ||
onChange={(e) => { | ||
changePlanName(e.target.value); | ||
}} | ||
className={`w-full truncate border-mainbutton5 bg-transparent outline-none duration-100 ease-in-out before:transition-all ${ | ||
isEditing ? "border-b-2 font-normal" : " " | ||
}`} | ||
disabled={!isEditing} | ||
/> | ||
<CiEdit | ||
className="ml-2 transform cursor-pointer transition-transform hover:scale-110 active:scale-90" | ||
onClick={handleEditClick} | ||
/> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zrób z tego formularz, żeby też przy kliknięciu enterem nazwa się zapisywała
src/pages/createplan/[id].tsx
Outdated
className={`w-full truncate border-mainbutton5 bg-transparent outline-none duration-100 ease-in-out before:transition-all ${ | ||
isEditing ? "border-b-2 font-normal" : " " | ||
}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tutaj zapraszam do uzycia cn
z shadcn'a do zrobienia isEditing
src/pages/createplan/[id].tsx
Outdated
<CiEdit | ||
className="ml-2 transform cursor-pointer transition-transform hover:scale-110 active:scale-90" | ||
onClick={handleEditClick} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i też tbh, przy edytowaniu fajnie jakby to się na jakiś checkmark zamieniało?
w sensie
nie da się edytować -> przycisk ten CiEdit
da się edytować -> jakiś checkmark co oznacza zapisanie
i też tbh, zrobiłbym to jako button z shadcn'a
Można zmieniać tytuły planów. Jest naprawiony navbar ktory na obu widokach (createplan, plans) wyglada tak samo teraz i jest wycentrowany odpowiednio. Input planu imo siedzi ladnie, nic ladniejszego nie wpadlo mi do glowy. Trzeba bedzie naprawic jeszcze footery, moge sie tym tez zajac potem, bo jest tam troche najebane dziwnych rzeczy.