Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mobile version fix & link prefetch #99

Merged
merged 3 commits into from
Nov 24, 2024
Merged

Conversation

qamarq
Copy link
Member

@qamarq qamarq commented Nov 24, 2024

This pull request includes several changes to the frontend package, primarily focusing on updating dependencies, modifying the navbar component, and enhancing the login and home page components.

Dependency Updates:

  • Added node-fetch version ^3.3.2 to frontend/package.json and frontend/package-lock.json. [1] [2]
  • Added data-uri-to-buffer version 4.0.1 to frontend/package-lock.json.
  • Added fetch-blob version 3.2.0 to frontend/package-lock.json.
  • Added formdata-polyfill version 4.0.10 to frontend/package-lock.json.
  • Added web-streams-polyfill version 3.3.3 to frontend/package-lock.json.

Component Modifications:

  • Modified the navbar component to adjust the height of the mobile menu icon.
  • Updated the LoginPage component to include prefetch={false} in the login link.
  • Updated the JoinUsBlock component to include prefetch={false} in the login link and adjust the flex layout.
  • Updated the HomePage component to remove the md:text-left class from the <h1> element and add text-balance to the <p> element. [1] [2]

API Route Changes:

  • Added dynamic = "force-dynamic" export to frontend/src/app/api/callback/route.ts.
  • Removed the fetch parameter from the tokens object in frontend/src/app/api/callback/route.ts and frontend/src/lib/usos.ts. [1] [2]
  • Set the secure flag to true for cookies in the GET function in frontend/src/app/api/login/route.ts.

Service and Client Changes:

  • Removed the LRUCache implementation and the fetch parameter from the createClient function in frontend/src/services/usos/usosClient.ts. [1] [2]

@qamarq qamarq marked this pull request as ready for review November 24, 2024 12:54
@qamarq qamarq self-assigned this Nov 24, 2024
@qamarq qamarq merged commit ba9a172 into main Nov 24, 2024
1 check passed
@qamarq qamarq deleted the fix/mobile-version-fix branch November 24, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant