Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement and NEW feature to Waveform.py #147

Closed
ruhi47 opened this issue Jun 20, 2024 · 8 comments · Fixed by #160
Closed

Enhancement and NEW feature to Waveform.py #147

ruhi47 opened this issue Jun 20, 2024 · 8 comments · Fixed by #160
Assignees

Comments

@ruhi47
Copy link

ruhi47 commented Jun 20, 2024

Summary of Changes to Waveform.py:

  • Add error handling for PyAudio initialization.
  • Consolidate GUI update functions.
  • Add dynamic resizing of the graph canvas.
  • Add features to save and load audio data.

I am GSSOC'24 Contributor, please assign me this issue. Thank you!

Copy link

Congratulations, @ruhi47! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@dinxsh
Copy link
Collaborator

dinxsh commented Jun 24, 2024

save function already exists but if you want to work on the others feel free to @ruhi47

@ruhi47
Copy link
Author

ruhi47 commented Jun 24, 2024

Thank you !!

@tkshsbcue
Copy link
Contributor

i would like to work on this issue please

@tkshsbcue
Copy link
Contributor

@dinxsh @ruhi47 i just wanted to ask one thing before starting what do mean by the 3 points like can explain it bit more so that i can fix them more efficiently
Thanks

@dinxsh
Copy link
Collaborator

dinxsh commented Jul 2, 2024

if you mean level numbers its the difficulty of level an issue has to be solved @tkshsbcue

@tkshsbcue
Copy link
Contributor

tkshsbcue commented Jul 2, 2024

@dinxsh im saying can elaborate issue more what are these issues are
->Add error handling for PyAudio initialization.(which i get mostly)
->Consolidate GUI update functions.
->Add dynamic resizing of the graph canvas.
Like I'm unable to locate them

@tkshsbcue
Copy link
Contributor

@dinxsh i have made a PR request please look into it

@dinxsh dinxsh linked a pull request Jul 3, 2024 that will close this issue
Soumya-Kushwaha pushed a commit that referenced this issue Jul 13, 2024
Fixes

->Added error handling for PyAudio initialization.
->Consolidate GUI update functions.
->Add dynamic resizing of the graph canvas.

Co-authored-by: tkshsbcue <kumar.tanay397@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants