Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #147 #160

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Conversation

tkshsbcue
Copy link
Contributor

@tkshsbcue tkshsbcue commented Jul 2, 2024

->Added error handling for PyAudio initialization.
->Consolidate GUI update functions.
->Add dynamic resizing of the graph canvas.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @tkshsbcue! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@tkshsbcue tkshsbcue changed the title Fixes Fixes issue #147 Jul 2, 2024
@dinxsh dinxsh linked an issue Jul 3, 2024 that may be closed by this pull request
Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, could you add a screenshot of the output

@tkshsbcue
Copy link
Contributor Author

@dinxsh these where codebase related changes so refer to the code

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, looks good to me. good work!

@dinxsh dinxsh requested review from sanjay-kv, Soumya-Kushwaha and jessicachawla and removed request for sanjay-kv July 12, 2024 04:00
@Soumya-Kushwaha Soumya-Kushwaha merged commit 6027a29 into Soumya-Kushwaha:main Jul 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement and NEW feature to Waveform.py
3 participants