Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UI to call and python pages from home page #108 #145

Merged
merged 6 commits into from
Jun 21, 2024

Conversation

Khushalsarode
Copy link
Contributor

@Khushalsarode Khushalsarode commented Jun 18, 2024

PR Title

Calling python pages from home page

Description

  • renamed main landing to home
  • added new layout design to home
  • calling function/waveforms from home page
  • added graphics image on home page

Linked Issue

Closes #108

Changes and Additions

  • change of code in home
  • adding of image in folder
  • adding gitignore

Testing and Validation

  • call working fine
  • pages loading

Additional Context or Information

  • wanted to remove menu call for each page from each page but due to conflict can't & they are not functional

Checklist

Please ensure you've completed the following tasks:

  • [ x ] Code is up to date with the project's latest version
  • [ x ] All tests have been run and passed
  • [ x ] Code has been reviewed for correctness and readability
  • [ x ] Followed the project's coding guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Khushalsarode! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Khushalsarode Khushalsarode changed the title New UI to call and python pages from home page New UI to call and python pages from home page #108 Jun 19, 2024
@Khushalsarode
Copy link
Contributor Author

Khushalsarode commented Jun 19, 2024

need review?
shall I rearrange the folder structure! it will be neat

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would suggest resolving conflicts before moving ahead

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did u test this? also just to be sure could you send me the screenshots of the output with your changes

@Khushalsarode
Copy link
Contributor Author

Khushalsarode commented Jun 21, 2024

did u test this? also just to be sure could you send me the screenshots of the output with your changes

Yes tested running fine
Sure

Screenshot 2024-06-22 000925
Screenshot 2024-06-22 001052

@Khushalsarode Khushalsarode requested a review from dinxsh June 21, 2024 18:44
Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me, good job!

Copy link
Collaborator

@jessicachawla jessicachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Soumya-Kushwaha Soumya-Kushwaha merged commit 70fe4b0 into Soumya-Kushwaha:main Jun 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an new User Interface for app and linking the functions window to it!
4 participants