Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Depth and Perspective Visualizer #158

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Conversation

abckhush
Copy link
Contributor

@abckhush abckhush commented Jul 1, 2024

Fixes: #155

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @abckhush! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@abckhush
Copy link
Contributor Author

@dinxsh Kindly review this PR. It's been a week

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. could you add a screenshot of the output. sorry for the delayed review!

@abckhush
Copy link
Contributor Author

image
image

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, good work

@abckhush
Copy link
Contributor Author

@Soumya-Kushwaha Kindly review this.

@dinxsh dinxsh requested a review from Soumya-Kushwaha July 11, 2024 20:36
@abckhush
Copy link
Contributor Author

abckhush commented Jul 13, 2024

Kindly merge this. @Soumya-Kushwaha @dinxsh

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a conflict now, could you check @abckhush

@abckhush
Copy link
Contributor Author

abckhush commented Jul 15, 2024

@dinxsh resolved.

mainLanding.py Outdated Show resolved Hide resolved
@abckhush
Copy link
Contributor Author

@dinxsh done.

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@dinxsh dinxsh merged commit 6a67da6 into Soumya-Kushwaha:main Jul 16, 2024
3 checks passed
@dinxsh dinxsh added the gssoc label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: New Visualizer with Depth and Perspective
3 participants