Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the UI and updated two py files #159

Merged
merged 6 commits into from
Jul 13, 2024

Conversation

Priyaanshucodez
Copy link
Contributor

Improved The UI with reference to #157 and updated two more files (Amplitude visualizer and Energy visualizer)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Priyaanshucodez! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@Priyaanshucodez
Copy link
Contributor Author

@dinxsh created the pr for the issue #157

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, could you add more margins between the buttons and charts in amplifier-frequency.py and energy-frequency .py file @Priyaanshucodez

@Priyaanshucodez
Copy link
Contributor Author

looks good, could you add more margins between the buttons and charts in amplifier-frequency.py and energy-frequency .py file @Priyaanshucodez

ok sir

@Priyaanshucodez
Copy link
Contributor Author

@dinxsh i tried to increase the Margin but somehow it wasn't looking good so i changed the UI to a simpler version opening three different tabs for each task .
just have a look ...should i merge this ?
Screenshot (60)
Screenshot (61)
Screenshot (62)

@Priyaanshucodez
Copy link
Contributor Author

i created the pr @dinxsh sir and @Soumya-Kushwaha Ma'am ....Just have a look and I had a request that if you could assign this as a level 3 issue instead of level 2 since a lot of changes i had to do ..I would be really grateful ...Rest it was great collaborating on this project with both of you .

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assigned labels, looks neat. good job!

@Priyaanshucodez
Copy link
Contributor Author

@Soumya-Kushwaha Ma'am your review is left ...Kindly review and close the issue .

@Priyaanshucodez
Copy link
Contributor Author

@Soumya-Kushwaha Ma'am your review is left ...Kindly review and close the issue .

Plz review it from your side

@dinxsh dinxsh requested a review from Soumya-Kushwaha July 4, 2024 09:40
@Priyaanshucodez
Copy link
Contributor Author

@dinxsh Sir there has been no reply from @Soumya-Kushwaha Ma'am ...I emailed her too ..Kindly inform her from your side .

@Priyaanshucodez
Copy link
Contributor Author

@Soumya-Kushwaha Ma'am plz review the PR ..It's been over 1 week now

@Priyaanshucodez
Copy link
Contributor Author

Ma'am plz close this one ...@dinesh changed the level from 2 to 3

@Soumya-Kushwaha Soumya-Kushwaha merged commit 6e7f87c into Soumya-Kushwaha:main Jul 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants