Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added zero-crossing-line visualizer #164

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

PDBharadwaj
Copy link
Contributor

I have added zero-crossing line visualizer to the repo.
This PR fixes #162.
@Soumya-Kushwaha @dinxsh Kindly review and merge this PR.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @PDBharadwaj! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm , could you add a screenshot of the output

@PDBharadwaj
Copy link
Contributor Author

lgtm , could you add a screenshot of the output

zcr.mp4

@PDBharadwaj
Copy link
Contributor Author

@dinxsh @Soumya-Kushwaha Please review and merge my PR.

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good job!

@Soumya-Kushwaha Soumya-Kushwaha self-requested a review July 31, 2024 13:43
@Soumya-Kushwaha Soumya-Kushwaha merged commit 980d1b3 into Soumya-Kushwaha:main Jul 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]Add a new visualizer for zero-crossing rate
3 participants