Thread safe PluginManager #3771
Open
+84
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think frameworks should pay the price for unconventional usage by users |
I do not see additonal locks in hot paths, so the price to pay is small. |
I agree, but the blocking time would be even less if command and event related stuff would have seperate locks as they dont need to be synchronized with each other |
|
Agree they should be separate locks, otherwise no issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a ReadWriteLock lock to methods modifying the commandMap and listenersByPlugin collections, ensuring thread safe for the PluginManager.
This is necessary because some plugins may register their commands or listeners asynchronously or in parallel while BungeeCord is still loading plugins or when for example a plugin registers its commands dynamically in some specific scenarios.