Fix trace proxy, improve logs #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 26, 2024
nipap/nipap/tracing.py
Outdated
| return post(f'{endpoint}{path}', data=request.data, headers=request.headers).content | ||
|
|
||
| # Remove Host-header as it's set to the host running nipapd. | ||
| headers = { k: v for k, v in request.headers } |
There was a problem hiding this comment.
whitespace after '{'
whitespace before '}'
Fix the tracing proxy function by removing the Host header from the headers received from tracing client before POST:ing it to the tracing receiver. Improve logging of how the setup of tracing is progressing.
garberg
force-pushed
the
nipapd_otel_proxy
branch
from
68e6f71 to
5612026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the tracing proxy function by removing the Host header from the headers received from tracing client before POST:ing it to the tracing receiver.
Improve logging of how the setup of tracing is progressing.