Merge pynipap to single file #1396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid hogging the global name "tracing", merged tracing.py into pynipap.py.
houndci-bot
reviewed
Aug 14, 2024
| current_span.set_attribute("net.peer.transport", "ip_tcp") | ||
| connection.putheader("traceparent", | ||
| "00-" + hex(current_span.get_span_context().trace_id)[2:].zfill(32) + "-" + hex( | ||
| current_span.get_span_context().span_id)[2:].zfill(16) + "-0" + ("1" if current_span.is_recording() else "0")) |
There was a problem hiding this comment.
line too long (151 > 79 characters)
| current_span.set_attribute("net.peer.port", connection.port) | ||
| current_span.set_attribute("net.peer.transport", "ip_tcp") | ||
| connection.putheader("traceparent", | ||
| "00-" + hex(current_span.get_span_context().trace_id)[2:].zfill(32) + "-" + hex( |
There was a problem hiding this comment.
line too long (117 > 79 characters)
| result = super().request(host, handler, request_body, verbose) | ||
| current_span.set_attribute("http.status_code", 200) | ||
| except xmlrpclib.ProtocolError as protocolError: | ||
| current_span.set_attribute("http.status_code", protocolError.errcode) |
There was a problem hiding this comment.
line too long (89 > 79 characters)
| with tracer.start_as_current_span("POST XML request", context.get_current(), SpanKind.CLIENT): | ||
| current_span = trace.get_current_span() | ||
| try: | ||
| result = super().request(host, handler, request_body, verbose) |
There was a problem hiding this comment.
line too long (82 > 79 characters)
| headers=headers, context=context) | ||
|
|
||
| def request(self, host, handler, request_body, verbose=False): | ||
| with tracer.start_as_current_span("POST XML request", context.get_current(), SpanKind.CLIENT): |
There was a problem hiding this comment.
line too long (106 > 79 characters)
| return decorated | ||
|
|
||
|
|
||
| class TracingXMLTransport(xmlrpclib.Transport): |
| index += 1 | ||
| try: | ||
| span.set_attribute("username", AuthOptions().options['username']) | ||
| span.set_attribute("authoritative_source", AuthOptions().options['authoritative_source']) |
There was a problem hiding this comment.
line too long (109 > 79 characters)
| break | ||
| index += 1 | ||
| try: | ||
| span.set_attribute("username", AuthOptions().options['username']) |
There was a problem hiding this comment.
line too long (85 > 79 characters)
| for parameter in signature.parameters: | ||
| if index > 0: | ||
| try: | ||
| span.set_attribute("argument." + parameter, str(args[index])) |
There was a problem hiding this comment.
line too long (89 > 79 characters)
| trace.set_tracer_provider(provider) | ||
|
|
||
|
|
||
| def create_span(f): |
houndci-bot
reviewed
Aug 14, 2024
| processor = BatchSpanProcessor(OTLPSpanExporter(endpoint=endpoint)) | ||
| else: | ||
| processor = BatchSpanProcessor( | ||
| opentelemetry.exporter.otlp.proto.http.trace_exporter.OTLPSpanExporter(endpoint=endpoint)) |
There was a problem hiding this comment.
line too long (106 > 79 characters)
| tracer = trace.get_tracer("pynipap") | ||
|
|
||
|
|
||
| def init_tracing(service_name, endpoint, sampler, use_grpc=True): |
| try: | ||
| from opentelemetry import trace, context | ||
| from opentelemetry.trace import SpanKind, INVALID_SPAN | ||
| from opentelemetry.exporter.otlp.proto.grpc.trace_exporter import OTLPSpanExporter |
There was a problem hiding this comment.
line too long (86 > 79 characters)
| @@ -17,7 +17,7 @@ | |||
| author_email = pynipap.__author_email__, | |||
| license = pynipap.__license__, | |||
| url = pynipap.__url__, | |||
| py_modules = ['pynipap','tracing'], | |||
| py_modules = ['pynipap'], | |||
There was a problem hiding this comment.
unexpected spaces around keyword / parameter equals
|
Fixed in #1412 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid hogging the global name "tracing", merged tracing.py into pynipap.py.
pynipap is a bit of a beast and really should be split up in smaller files in a python package, but I'll leave that for another day...