Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] simd count_zero in arm #54937

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

before-Sunrise
Copy link
Contributor

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
  • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

Signed-off-by: before-Sunrise <unclejyj@gmail.com>
// result[i] = result[i] & 0x1
result = vandq_u32(result, vdupq_n_u32(1));
count += vaddvq_u32(result);
}
#endif

for (; data < end; ++data) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most risky bug in this code is:
The condition defined(__POPCNT__) is unnecessary and incorrect for ARM NEON intrinsics, which do not require the POPCNT feature.

You can modify the code like this:

#elif defined(__ARM_NEON) && defined(__aarch64__)
// Remove the unnecessary check for __POPCNT__
const T* end16 = data + (size / 16 * 16);
for (; data < end16; data += 16) {
    uint8x16_t vdata = vld1q_u8(data);
    // result[i] = vdata[i] == 0 ? 0xFF : 0x00
    uint8x16_t result = vceqq_u8(vdata, vdupq_n_u8(0));
    // result[i] = result[i] & 0x1
    result = vandq_u8(result, vdupq_n_u8(1));
    count += vaddvq_u8(result);
}

...

#elif defined(__ARM_NEON) && defined(__aarch64__)
// Remove the unnecessary check for __POPCNT__
const T* end4 = data + (size / 4 * 4);
for (; data < end4; data += 4) {
    uint32x4_t vdata = vld1q_u32(data);
    // result[i] = vdata[i] == 0 ? 0xFF : 0x00
    uint32x4_t result = vceqq_u32(vdata, vdupq_n_u32(0));
    // result[i] = result[i] & 0x1
    result = vandq_u32(result, vdupq_n_u32(1));
    count += vaddvq_u32(result);
}
#endif

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@ZiheLiu ZiheLiu enabled auto-merge (squash) January 22, 2025 08:58
@ZiheLiu ZiheLiu merged commit 3a3a45c into StarRocks:main Jan 22, 2025
52 checks passed
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jan 22, 2025
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jan 22, 2025
Copy link
Contributor

mergify bot commented Jan 22, 2025

backport branch-3.4

✅ Backports have been created

Copy link
Contributor

mergify bot commented Jan 22, 2025

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 22, 2025
Signed-off-by: before-Sunrise <unclejyj@gmail.com>
(cherry picked from commit 3a3a45c)
mergify bot pushed a commit that referenced this pull request Jan 22, 2025
Signed-off-by: before-Sunrise <unclejyj@gmail.com>
(cherry picked from commit 3a3a45c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants