-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] simd count_zero in arm #54937
Conversation
Signed-off-by: before-Sunrise <unclejyj@gmail.com>
// result[i] = result[i] & 0x1 | ||
result = vandq_u32(result, vdupq_n_u32(1)); | ||
count += vaddvq_u32(result); | ||
} | ||
#endif | ||
|
||
for (; data < end; ++data) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most risky bug in this code is:
The condition defined(__POPCNT__)
is unnecessary and incorrect for ARM NEON intrinsics, which do not require the POPCNT feature.
You can modify the code like this:
#elif defined(__ARM_NEON) && defined(__aarch64__)
// Remove the unnecessary check for __POPCNT__
const T* end16 = data + (size / 16 * 16);
for (; data < end16; data += 16) {
uint8x16_t vdata = vld1q_u8(data);
// result[i] = vdata[i] == 0 ? 0xFF : 0x00
uint8x16_t result = vceqq_u8(vdata, vdupq_n_u8(0));
// result[i] = result[i] & 0x1
result = vandq_u8(result, vdupq_n_u8(1));
count += vaddvq_u8(result);
}
...
#elif defined(__ARM_NEON) && defined(__aarch64__)
// Remove the unnecessary check for __POPCNT__
const T* end4 = data + (size / 4 * 4);
for (; data < end4; data += 4) {
uint32x4_t vdata = vld1q_u32(data);
// result[i] = vdata[i] == 0 ? 0xFF : 0x00
uint32x4_t result = vceqq_u32(vdata, vdupq_n_u32(0));
// result[i] = result[i] & 0x1
result = vandq_u32(result, vdupq_n_u32(1));
count += vaddvq_u32(result);
}
#endif
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
@Mergifyio backport branch-3.4 |
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
✅ Backports have been created
|
Signed-off-by: before-Sunrise <unclejyj@gmail.com> (cherry picked from commit 3a3a45c)
Signed-off-by: before-Sunrise <unclejyj@gmail.com> (cherry picked from commit 3a3a45c)
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: