Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix unlimit delete_txn_log request from FE side (backport #54857) #54987

Closed
wants to merge 1 commit into from
Closed

[BugFix] Fix unlimit delete_txn_log request from FE side (backport #54857) #54987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions fe/fe-core/src/main/java/com/starrocks/transaction/PublishVersionDaemon.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
import com.starrocks.lake.Utils;
import com.starrocks.lake.compaction.Quantiles;
import com.starrocks.proto.DeleteTxnLogRequest;
import com.starrocks.proto.DeleteTxnLogResponse;
import com.starrocks.proto.TxnInfoPB;
import com.starrocks.rpc.BrpcProxy;
import com.starrocks.rpc.LakeService;
Expand All @@ -79,6 +80,7 @@
import java.util.Objects;
import java.util.Set;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.Future;
import java.util.concurrent.ThreadPoolExecutor;
import java.util.stream.Collectors;
import javax.validation.constraints.NotNull;
Expand Down Expand Up @@ -558,6 +560,62 @@ public boolean publishPartitionBatch(Database db, long tableId, PartitionPublish
return true;
}

<<<<<<< HEAD
=======
private void deleteTxnLogIgnoreError(ComputeNode node, DeleteTxnLogRequest request) {
try {
LakeService lakeService = BrpcProxy.getLakeService(node.getHost(), node.getBrpcPort());
// just ignore the response, for we don't care the result of delete txn log
// and vacuum will clan the txn log finally if it failed.
// make sure sync wait for the RPC call to avoid too many RPC call existed in BE/CN side
Future<DeleteTxnLogResponse> responseFuture = lakeService.deleteTxnLog(request);
DeleteTxnLogResponse response = responseFuture.get();
if (response != null && response.status != null && response.status.statusCode != 0) {
LOG.warn("delete txn log request return with err: " + response.status.errorMsgs.get(0));
}
} catch (Exception e) {
LOG.warn("delete txn log error: " + e.getMessage());
}
}

private Runnable getDeleteTxnLogTask(TransactionStateBatch batch, List<Long> txnIds) {
return () -> {
// For each partition, send a delete request to all the tablets in the partition
for (Map.Entry<Long, Map<ComputeNode, Set<Long>>> entry : batch.getPartitionToTablets().entrySet()) {
Map<ComputeNode, Set<Long>> nodeToTablets = entry.getValue();
for (Map.Entry<ComputeNode, Set<Long>> entryItem : nodeToTablets.entrySet()) {
ComputeNode node = entryItem.getKey();
DeleteTxnLogRequest request = new DeleteTxnLogRequest();
request.tabletIds = new ArrayList<>(entryItem.getValue());
request.txnIds = txnIds;
deleteTxnLogIgnoreError(node, request);
}
}
};
}

private Runnable getDeleteCombinedTxnLogTask(TransactionStateBatch batch, List<Long> txnIds) {
return () -> {
List<TxnInfoPB> txnInfoPBList = new ArrayList<>();
for (Long txnId : txnIds) {
TxnInfoPB txnInfoPB = new TxnInfoPB();
txnInfoPB.txnId = txnId;
txnInfoPB.combinedTxnLog = true;
txnInfoPBList.add(txnInfoPB);
}
// For each partition, send a delete request to any tablet in the partition
for (Map.Entry<Long, Map<ComputeNode, Set<Long>>> entry : batch.getPartitionToTablets().entrySet()) {
Map.Entry<ComputeNode, Set<Long>> entryItem = entry.getValue().entrySet().iterator().next();
ComputeNode node = entryItem.getKey();
DeleteTxnLogRequest request = new DeleteTxnLogRequest();
request.tabletIds = new ArrayList<>(entryItem.getValue());
request.txnInfos = txnInfoPBList;
deleteTxnLogIgnoreError(node, request);
}
};
}

>>>>>>> a6b14d75ae ([BugFix] Fix unlimit delete_txn_log request from FE side (#54857))
private void submitDeleteTxnLogJob(TransactionStateBatch txnStateBatch) {
try {
// TODO: do not send abortTxn() requests for transactions with combined txn log.
Expand Down
Loading