-
-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Gaia ID in other functionalities #4064
base: master
Are you sure you want to change the base?
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
There is no official start number of Gaia but practically the lowest Gaia source id is 4295806720 for DR3 in the whole DR3 catalog (not just stellarium). In order for a Gaia star in any data release to even has a source id lower than 34359738368, it need to fall within a specific area 0.7 arcmin2 of the sky. Hence I think it is safe to say the lowest Gaia source in the future data relase will bigger than the biggest HIP id. I have updated the |
Currently the support of Gaia ID is limited in other functionalities like displaying star name. The fact that Hipparcos and Gaia ID will not overlap means one can just check if the number specify in the file is larger than the possible Hipparcos ID to infer that is a Gaia ID. And current column for Hipparcos in data files can be mixed with Gaia ID directly.
So far, I have added Eta Carinae (Gaia DR3 5350358584482202880) as a test and added support for Gaia ID to asterism.
cross-id.dat
is updated to include all SAO stars with their corresponding Gaia DR3, HD, HR if no already in the file.Fixes #4043
Fixes #633
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: