feat: ability air lock #391
Conversation
Codecov Report
@@ Coverage Diff @@
## main #391 +/- ##
================================================
+ Coverage 95.4101% 95.4257% +0.0156%
================================================
Files 16 16
Lines 2048 2055 +7
================================================
+ Hits 1954 1961 +7
Misses 72 72
Partials 22 22
Continue to review full report at Codecov.
|
| if pkmn.Ability == AbilityAirLock { | ||
| b.metadata[MetaWeatherDisabled] = true | ||
| } |
There was a problem hiding this comment.
Should this be another transaction so it's possible to announce it? Something like AbilityEffectTransaction.
There was a problem hiding this comment.
I think it would be hard to make a transaction generic enough to be able to handle these types of cases. Right now the metadata fields are the only interface{} types. I also considered this being a potential battle rule (to disable weather), which doesn't make sense for it being a transaction.
This seems like the easiest way to ensure that we always have this check in the beginning of a round.
| var _ = Describe("Ability: Air Lock", func() { | ||
| a := Agent(new(dumbAgent)) | ||
|
|
||
| It("should negate the effects of weather", func() { |
There was a problem hiding this comment.
Can we have a test to see if the effect gets removed when the pokemon is removed from the battlefield?
No description provided.