Display free rooms based on solely the room scheduling website #22
Conversation
|
Great implementation of this feature! I agree that this is a very nice starting point -- you managed to scrape the data necessary (we should come to an agreement on what library or libraries to use for HTML scraping in Javascript), as well as implement the display of said data. I believe that as time goes on we will find what works best and standardize our features to use a similar structure, but again, great work! |
| @@ -0,0 +1,335 @@ | |||
| import ROOMS from './Rooms'; | |||
There was a problem hiding this comment.
I would say just to be safe, we would extract the rooms based on what the website presents to us visually (as opposed to hard-coding the room values). This will be easier to do with a web-scraping or HTML-parsing library.
| for (let i = 0; i < ROOMS.length; i++) { | ||
| //match all of the tables loaded in the HTML to a the name of a room | ||
| //checking by hand, it seems there are only as many tables as there are rooms | ||
| //no other tables for decoration or some other data, etc. | ||
| roomTableDict[ROOMS[i]] = roomTables[i]; | ||
| } |
There was a problem hiding this comment.
This construct can usually be replaced with for..of syntax. It's cleaner and usually more intuitive.
|
|
||
| chrome.alarms.onAlarm.addListener(alarm => { | ||
| if (alarm.name === 'rooms') { | ||
| getAvailableRooms(new Date()).then(rooms => { |
There was a problem hiding this comment.
Consider using moment.js for anything related to dates and times. It integrates very easily with Javascript Date objects and it's already part of the project dependencies.
| @@ -0,0 +1,108 @@ | |||
| const ROOMS = [ | |||
There was a problem hiding this comment.
Again, scraping this instead of hard-coding values is probably one of the next steps.
This would be a first step to resolving #8. This displays the rooms available according to the Stevens scheduling website in the popup. A known limitation of this is that it cannot determine if the room has been booked by something like a club- this does not use any data from Virtual EMS. It could also look prettier in the popup, but there are no features with any CSS yet, so a new issue could be opened for that.