Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple images in one page #1760

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sorydi3
Copy link
Contributor

@sorydi3 sorydi3 commented Aug 25, 2024

Description

This pull address the following user request. request

AFFECTED UI LINK:

Note: All other features work as usual.

New Feature: Add multiple images in one page.

  • Template Selection: Users can choose from a set of predefined templates that dictate how images are organised on each page. Available templates include:

    • 1x2 (Two per page): Two images will be arranged on each page. (from left to right)
    • 2x2 (Four per page): Four images will be arranged on each page. (from left to right)
    • 2x3 (Six per page): Six images will be arranged on each page. (from left to right)
  • Handling Fewer Images: If fewer images are selected than the number of slots in the chosen template, the extra slots will be left empty. Only the selected images will be displayed.

  • Size and Spacing: The size and spacing of images will be automatically adjusted according to the selected template, maintaining the aspect ratio of each image. Users will not need to make any manual adjustments, as the templates will optimize the layout to fit the specified number of images per page.

Closes #(1400)

Exemple:

UI:

Screenshot 2024-08-25 at 20 52 07

Output for 1x2 ( 1 row two colomn ):

Screenshot 2024-08-25 at 20 57 18

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@github-actions github-actions bot added Java Pull requests that update Java code Front End Issues or pull requests related to front-end development Translation API API-related issues or pull requests labels Aug 25, 2024
@Frooodle
Copy link
Member

Frooodle commented Aug 25, 2024

Love the idea,
I noticed in your screenshot 2 images produced 1 page with image but also made one blank page?

I also think instead of having the templates defined like the grid layout done by our
https://stirlingpdf.io/split-pdf-by-sections
would be better suited
image

@sorydi3
Copy link
Contributor Author

sorydi3 commented Aug 27, 2024

Yep look good to me also , I did not know we had this feature. I'll do the changes.
The blank page is because i uploaded the wrong foto.

@sorydi3 sorydi3 marked this pull request as draft August 27, 2024 19:07
@github-actions github-actions bot added Back End Issues related to back-end development Security Security-related issues or pull requests labels Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

🚀 Translation Verification Summary

🔄 Reference Branch: pr-branch-messages_en_GB.properties

📃 File Check: messages_ar_AR.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_bg_BG.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_ca_CA.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_cs_CZ.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_de_DE.properties

  1. Test Status:Passed
  2. Test Status:Failed
  • Issue:
    • Extra keys in messages_de_DE.properties: pdfPrompwt that are not present in pr-branch-messages_en_GB.properties.
    • Missing keys in pr-branch-messages_en_GB.properties: pdfPrompt that are not present in messages_de_DE.properties.

📃 File Check: messages_el_GR.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_en_GB.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_en_US.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_es_ES.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_eu_ES.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_fr_FR.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_hi_IN.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_hr_HR.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_hu_HU.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_id_ID.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_it_IT.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_ja_JP.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_ko_KR.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_nl_NL.properties

  1. Test Status:Passed
  2. Test Status:Passed

📃 File Check: messages_no_NB.properties

  1. Test Status:Passed
  2. Test Status:Passed

❌ Overall Check Status: Failed

@sorydi3 please check your translation if it conforms to the standard. Follow the format of messages_en_GB.properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API-related issues or pull requests Back End Issues related to back-end development Front End Issues or pull requests related to front-end development Java Pull requests that update Java code needs-changes Security Security-related issues or pull requests Translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants