Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add optional multiplier parameter for ConVar material proxy #1326

Open
ErinRoseWebs69 opened this issue Jan 9, 2025 · 3 comments
Labels
Type: Enhancement This is something that improves upon an already existing thing.

Comments

@ErinRoseWebs69
Copy link

What would this enhancement be for?

Rendering

Describe your enhancement suggestion in more detail

Currently $color, at least via pulling ConVar values, requires a 0-1 color range, but this breaks cvars such as cl_portals_sp_primary_color and cl_portals_sp_secondary_color, as those require a 0-255 color range. Allowing the material proxy to utilize both 0-1 and 0-255 range would be great for cvar pulling or other material proxy shenanigans

@ErinRoseWebs69 ErinRoseWebs69 added the Type: Enhancement This is something that improves upon an already existing thing. label Jan 9, 2025
@craftablescience craftablescience changed the title Enhancement: Add Multiply for $color Enhancement: Add optional multiplier parameter for ConVar material proxy Jan 9, 2025
@TeamSpen210
Copy link

This doesn't really need to be built in? Define a material var with a custom name, write to that, then use a Multiply proxy after MaterialModify to do the multiplication. You could even just keep the one variable, and use it both for srcVar1 and resultVar.

@JJL772
Copy link
Member

JJL772 commented Jan 9, 2025

Might be nice to have as shorthand syntax.

@TeamSpen210
Copy link

True, several other proxies have a scale option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement This is something that improves upon an already existing thing.
Projects
None yet
Development

No branches or pull requests

3 participants