Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: OpenGL Normal Support #1332

Closed
ErinRoseWebs69 opened this issue Jan 13, 2025 · 3 comments
Closed

Feature: OpenGL Normal Support #1332

ErinRoseWebs69 opened this issue Jan 13, 2025 · 3 comments
Labels
Priority 4: Low Something that can be picked up for the next release, but can be kicked back if need be. Size 4: Small Something that will take up to a day to do. Type: Enhancement This is something that improves upon an already existing thing. Type: Feature This is something completely new that will be added. What: Graphics Graphics-related stuff

Comments

@ErinRoseWebs69
Copy link

Which component should be improved?

Rendering

Describe your feature suggestion in more detail

I know it's easier said than done, but it would be nice to have a material parameter for converting an OpenGL normal map to Direct3D:
$bumpisopengl, with a binary value of either 0 or 1. 0 obviously wont do anything, but 1 would automatically flip the green channel of the defined bumpmap to work for Source. would be a nice quality of life thing, since majority of texture programs utilize OpenGL rather than Direct3D
@ErinRoseWebs69 ErinRoseWebs69 added the Type: Feature This is something completely new that will be added. label Jan 13, 2025
@pivotman319-owo pivotman319-owo added What: Graphics Graphics-related stuff Priority 3: Medium Something that should be attempted/looked at for the next release, and done if possible. Size 4: Small Something that will take up to a day to do. Type: Enhancement This is something that improves upon an already existing thing. labels Jan 14, 2025
@distantjetlines
Copy link

Doesn't vtex2 already have an OpenGL option for converting normals?
https://wiki.stratasource.org/modding/util/vtex2

@SCell555 SCell555 added Priority 4: Low Something that can be picked up for the next release, but can be kicked back if need be. and removed Priority 3: Medium Something that should be attempted/looked at for the next release, and done if possible. labels Jan 15, 2025
@JJL772
Copy link
Member

JJL772 commented Jan 18, 2025

Out of scope. This would require a new combo or branch in almost every shader for little benefit. imo this would fit better as a texture flag, but why not just invert the green channel while you're modifying the texture at that point.

@JJL772 JJL772 closed this as completed Jan 18, 2025
@ErinRoseWebs69
Copy link
Author

fair enough lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority 4: Low Something that can be picked up for the next release, but can be kicked back if need be. Size 4: Small Something that will take up to a day to do. Type: Enhancement This is something that improves upon an already existing thing. Type: Feature This is something completely new that will be added. What: Graphics Graphics-related stuff
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@SCell555 @distantjetlines @pivotman319-owo @JJL772 @ErinRoseWebs69