Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build error relating to sourcepp #13

Merged
merged 2 commits into from
Jan 19, 2025
Merged

fix: build error relating to sourcepp #13

merged 2 commits into from
Jan 19, 2025

Conversation

craftablescience
Copy link
Member

Took a while but I finally remembered to do this

  • Fix compile error with latest sourcepp code
  • Disable all sourcepp libraries besides kvpp and vpkpp with a better method
  • Disable vpkpp's VPK v54 code

@craftablescience craftablescience self-assigned this Nov 11, 2024
JJL772
JJL772 approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@JJL772 JJL772 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR still relevant?

@craftablescience
Copy link
Member Author

I made this to theoretically fix a build error ender was having, I don't think it needs to be merged but would still be cool to pull in latest code

@JJL772
Copy link
Member

JJL772 commented Jan 19, 2025

Can I merge?

@craftablescience
Copy link
Member Author

Should be clear to

@JJL772 JJL772 merged commit 2f9ac62 into main Jan 19, 2025
4 checks passed
@craftablescience craftablescience deleted the fix/build branch January 19, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JJL772 JJL772 JJL772 approved these changes

Assignees

@craftablescience craftablescience

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craftablescience @JJL772