Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Improve imports and exports #48

Merged
merged 52 commits into from
Oct 25, 2024
Merged

Feat: Improve imports and exports #48

merged 52 commits into from
Oct 25, 2024

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented Aug 2, 2024 •
edited
Loading

  • Adds stremio-core-protobuf
  • stremio-core-android - workspace setup, use protobuf crate and improve imports

TODOs:

elpiel and others added 30 commits August 1, 2024 17:56
@elpiel
chore(stremio-core-android): update time dep. and introduce kotlin …
c37f31b 
…feature

Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
feat(stremio-core-protobuf): move proto files and codegen there and r…
51c604a 
…e-export in stremio-core-android

Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
chore: add workspace deps for stremio-* crates
ba59b4b 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
chore: rustfmt & clippy fixes + suppress missing safety docs for stre…
8d8a601 
…mio_core_android module

Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
chore(Cargo.toml): add prost and relative crates to workspace depende…
7264ed9 
…ncies

- use workspace deps. in stremio-core-protobuf

Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
fix(stremio-core-protobuf): build.rs - use CARGO_MANIFEST_DIR for pro…
641a7da 
…tobuf files location

Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
fix: proto - Descriptor renamed to Descriptor__ because of protoc com…
40ed286 
…piler

Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
feat(stremio-core-protobuf): move and generalize the bridge and model…
b91e04e 
… fields from stremio-core-android

Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
chore: bridge- move ToProtobuf and FromProtobuf traits
757f260 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
chore(fetch): Refactor to use async/await and remove either dep.
daff13a 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
feat(protobuf): add stremio-core-web dep. for mode (de)serialization
45c462f 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
feat(AndroidModelField): Impl From / Into Field
409a419 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
chore: Update stremio-core & stremio-core-web rev.
a711963 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
chore: rustfmt & clippy
bc5fda3 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
fix(stremio-core-protobuf): build script creates protobuf folder if i…
34bab4c 
…t's missing

Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
@elpiel
fix(ci): build - add protoc setup because of stremio-core-csharp
4d7d4b7 
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
@elpiel
chore(Cargo): add workspace deps for the fetch impl
260c524 
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
@elpiel
chore(android): AndroidModel should be enabled only by the env. impl …
8068ee7 
…with `kotlin` feature

Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
@elpiel
chore(stremio-core-protobuf): RuntimeEvent - remove the need of Clone…
a57079a 
… for the Model Field

Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
@elpiel
fix: clippy warnings and cleanup code for bridge action
924ac1a 
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
@elpiel
chore(stremio-core-android): Use protobuf crate
b047db3 
Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
@elpiel
ci: improve build by setting concurrency and protoc version + add dep…
87ed5f3 
…endabot.yml for outdated deps.

Signed-off-by: Lachezar Lechev <elpiel93@gmail.com>
@elpiel
feat(protobuf): field - add missing fields
cf337c5 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
fix: add missing model fields for android
0b1f3cc 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
feat(protobuf): add CatalogWithFiltersAll action for load in Board
f045bd5 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
feat: Discovery (CatalogsWithExtraAll) & Search (CatalogsWithExtra)
8636383 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
chore: use once_cell instead of lazy_static
aa87467 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
chore: bump core rev
946586e 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
fix: import
31bfd9b 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
chore: use stremio-core development branch and comment stremio-core-web
9758f3b 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
elpiel added 3 commits October 8, 2024 16:02
@elpiel
fix: clippy
27d72c3
@elpiel
chore: tweak workspace dependencies
b76df1b 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
feat(ci): build & release - optimize workflows
710cc4d 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel elpiel mentioned this pull request Oct 16, 2024
Closed
6 tasks
@elpiel elpiel marked this pull request as ready for review October 16, 2024 08:32
TheBeastLT
TheBeastLT reviewed Oct 17, 2024
View reviewed changes
src/commonMain/rust/model/model.rs Show resolved Hide resolved
stremio-core-protobuf/proto/stremio/core/types/manifest.proto Outdated Show resolved Hide resolved
stremio-core-protobuf/src/bridge/event.rs Outdated Show resolved Hide resolved
stremio-core-protobuf/src/bridge/loadable.rs Show resolved Hide resolved
stremio-core-protobuf/src/bridge/resource_loadable.rs Outdated Show resolved Hide resolved
stremio-core-protobuf/src/model/fields/catalogs_with_extra.rs Outdated Show resolved Hide resolved
stremio-core-protobuf/src/bridge/action.rs Outdated Show resolved Hide resolved
@elpiel
feat(stremio-core-protobuf): addon-detail replace addon stremio:// ur…
72bbd76 
…ls with https://

Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel elpiel force-pushed the feat/improve-imports-and-exports branch from 0d6562e to 72bbd76 Compare October 17, 2024 16:10
@elpiel
chore: address PR review comments
3586458 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel elpiel force-pushed the feat/improve-imports-and-exports branch 2 times, most recently from bce5084 to 1e808f1 Compare October 21, 2024 14:50
@elpiel
fix(stremio-core-protobuf): should include staticlib and dylib
2a363bc 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel elpiel force-pushed the feat/improve-imports-and-exports branch from 1e808f1 to 2a363bc Compare October 21, 2024 16:26
elpiel added 3 commits October 24, 2024 08:43
@elpiel
Merge branch 'master' into feat/improve-imports-and-exports
ab430f2
@elpiel
fix(stremio-core-android): Cargo - crate-type didn't work before so r…
ebf72b7 
…emove it completely because of failing release build

Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel
fix: build.gradle.kts - source dir for .proto files
711ba89 
Signed-off-by: Lachezar Lechev <lachezar@ambire.com>
@elpiel elpiel force-pushed the feat/improve-imports-and-exports branch from 4050570 to 711ba89 Compare October 24, 2024 11:08
@elpiel elpiel merged commit 7ca0ae9 into master Oct 25, 2024
1 check passed
@TheBeastLT TheBeastLT deleted the feat/improve-imports-and-exports branch October 25, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBeastLT TheBeastLT TheBeastLT left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elpiel @TheBeastLT @tymmesyde